Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move docker registry login values to repository environment #32

Merged
merged 3 commits into from
Jan 11, 2024

Conversation

WindzCUHK
Copy link
Contributor

@WindzCUHK WindzCUHK commented Nov 28, 2023

Description

as title

Changes

  • remove unused DELETE_UNTAGGED_IMAGES_TOKEN and DELETE_UNTAGGED_IMAGES_PER_PAGE
  • move DOCKER_REGISTRY_USER and DOCKER_REGISTRY_TOKEN_NAME to repository environment
  • rename DOCKER_REGISTRY_ORG => DOCKER_REGISTRY_ORG

Type of change

  • Bug fix
  • New feature
  • Refactoring (no functional changes, no api changes)
  • Non-code changes (update documentation, pipeline, etc.)

Flags

  • Breaks backward compatibility
  • Requires a documentation update
  • Has untestable code

Checklist

  • Followed the guidelines in the CONTRIBUTING document
  • Added prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip] in the PR title if necessary
  • Tested and linted the code
  • Commented the code
  • Made corresponding changes to the documentation
  • Passed all pipeline checking

Checklist for maintainer

  • Use Squash and merge
  • Double-confirm the merge message has prefix [skip ci]/[ci skip]/[no ci]/[skip actions]/[actions skip]
  • Delete the branch after merge

Signed-off-by: wfan <wfan@lycorp.co.jp>
Signed-off-by: wfan <wfan@lycorp.co.jp>
Signed-off-by: wfan <wfan@lycorp.co.jp>
Copy link
Contributor

@mlajkim mlajkim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.github/workflows/docker-build-publish.yaml Show resolved Hide resolved
@mlajkim mlajkim merged commit 2fb96f8 into master Jan 11, 2024
2 checks passed
@mlajkim mlajkim deleted the change-action-secret branch January 11, 2024 00:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants