Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and move to nixosModules #16

Merged
merged 3 commits into from
Aug 15, 2024
Merged

Conversation

DerDennisOP
Copy link
Contributor

@DerDennisOP DerDennisOP commented Jul 31, 2024

As spoken in #13

Help is very welcome :).

@DerDennisOP DerDennisOP force-pushed the refactor branch 2 times, most recently from d094afb to af6a6ff Compare July 31, 2024 19:55
@DerDennisOP DerDennisOP marked this pull request as ready for review July 31, 2024 19:55
@DerDennisOP
Copy link
Contributor Author

DerDennisOP commented Jul 31, 2024

Usually splitting up would be the right thing here. But I somehow ended up changing the entire project, so splitting up changes in 61 files would be a lot of work for me. I also did some formatting, which makes reviewing very hard, hopefully you are able to review it anyway.

@DerDennisOP DerDennisOP force-pushed the refactor branch 8 times, most recently from 2e62d62 to 65c127c Compare August 1, 2024 16:59
@D3vil0p3r D3vil0p3r merged commit f0cb0c3 into Athena-OS:main Aug 15, 2024
@DerDennisOP DerDennisOP deleted the refactor branch August 15, 2024 13:21
@AkechiShiro
Copy link
Contributor

This PR did break some stuff that has been fixed, as there was no tag 24.05, there shouldn't have been any full replace.

@DerDennisOP please tag me from now on in any change you would like to PR, I'll also attempt to leave a review and retest before a merge happens, as an extra pair of eyes as @D3vil0p3r might not have the time to cover large PRs.

@D3vil0p3r
Copy link
Member

@DerDennisOP
Copy link
Contributor Author

DerDennisOP commented Sep 4, 2024

@D3vil0p3r I would remove the string text in the default.nix file. It makes the nix code better readable, and the bashrc would then have the bashrc content. Currently both ways are in use, so you might remove the text parts that are overlaying with the bashrc file content.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants