Migrate to Quarkus #1520

Athou · 2024-08-18T05:53:38Z

Replace Dropwizard with Quarkus

…time in native mode

…n persistence contexts"

canoine · 2024-08-18T09:32:29Z

I meet a problem, but I don't know if the cause is this migration, or a PEBKAC :

[INFO] -------------------------------------------------------
[INFO]  T E S T S
[INFO] -------------------------------------------------------

(snip)

[INFO] Running com.commafeed.backend.HttpGetterTest
Handler org.mockserver.logging.StandardOutConsoleHandler is not defined
Handler org.mockserver.logging.StandardOutConsoleHandler is not defined
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
2024-08-18 11:18:36,072 INFO  [io.net.uti.int.NativeLibraryLoader] (MockServer-MockServer-workerEventLoop9) /tmp/libnetty_tcnative_linux_x86_648066554815368152247.so exists but cannot be executed even when execute permissions set; check volume for "noexec" flag; use -Dio.netty.native.workdir=[path] to set native working directory separately.
[ERROR] Tests run: 19, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 16.11 s <<< FAILURE! -- in com.commafeed.backend.HttpGetterTest
[ERROR] com.commafeed.backend.HttpGetterTest.ignoreInvalidSsl -- Time elapsed: 5.675 s <<< ERROR!
org.apache.hc.client5.http.ConnectTimeoutException: Connect to https://localhost:45819 [localhost/127.0.0.1] failed: Read timed out
	at java.base/sun.nio.ch.NioSocketImpl.timedRead(NioSocketImpl.java:288)
	at java.base/sun.nio.ch.NioSocketImpl.implRead(NioSocketImpl.java:314)
	at java.base/sun.nio.ch.NioSocketImpl.read(NioSocketImpl.java:355)
	at java.base/sun.nio.ch.NioSocketImpl$1.read(NioSocketImpl.java:808)
	at java.base/java.net.Socket$SocketInputStream.read(Socket.java:966)
	at java.base/sun.security.ssl.SSLSocketInputRecord.read(SSLSocketInputRecord.java:484)
	at java.base/sun.security.ssl.SSLSocketInputRecord.readHeader(SSLSocketInputRecord.java:478)
	at java.base/sun.security.ssl.SSLSocketInputRecord.decode(SSLSocketInputRecord.java:160)
	at java.base/sun.security.ssl.SSLTransport.decode(SSLTransport.java:111)
	at java.base/sun.security.ssl.SSLSocketImpl.decode(SSLSocketImpl.java:1510)
	at java.base/sun.security.ssl.SSLSocketImpl.readHandshakeRecord(SSLSocketImpl.java:1425)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:455)
	at java.base/sun.security.ssl.SSLSocketImpl.startHandshake(SSLSocketImpl.java:426)
	at org.apache.hc.client5.http.ssl.SSLConnectionSocketFactory.executeHandshake(SSLConnectionSocketFactory.java:345)
	at org.apache.hc.client5.http.ssl.SSLConnectionSocketFactory.createLayeredSocket(SSLConnectionSocketFactory.java:313)
	at org.apache.hc.client5.http.ssl.SSLConnectionSocketFactory.connectSocket(SSLConnectionSocketFactory.java:251)
	at org.apache.hc.client5.http.impl.io.DefaultHttpClientConnectionOperator.connect(DefaultHttpClientConnectionOperator.java:189)
	at org.apache.hc.client5.http.impl.io.PoolingHttpClientConnectionManager.connect(PoolingHttpClientConnectionManager.java:450)
	at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:162)
	at org.apache.hc.client5.http.impl.classic.InternalExecRuntime.connectEndpoint(InternalExecRuntime.java:172)
	at org.apache.hc.client5.http.impl.classic.ConnectExec.execute(ConnectExec.java:142)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.ProtocolExec.execute(ProtocolExec.java:192)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.ContentCompressionExec.execute(ContentCompressionExec.java:152)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.RedirectExec.execute(RedirectExec.java:116)
	at org.apache.hc.client5.http.impl.classic.ExecChainElement.execute(ExecChainElement.java:51)
	at org.apache.hc.client5.http.impl.classic.InternalHttpClient.doExecute(InternalHttpClient.java:170)
	at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:245)
	at org.apache.hc.client5.http.impl.classic.CloseableHttpClient.execute(CloseableHttpClient.java:188)
	at com.commafeed.backend.HttpGetter.getBinary(HttpGetter.java:100)
	at com.commafeed.backend.HttpGetter.getBinary(HttpGetter.java:74)
	at com.commafeed.backend.HttpGetterTest.ignoreInvalidSsl(HttpGetterTest.java:225)
	at java.base/java.lang.reflect.Method.invoke(Method.java:568)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1511)

(snip)

[INFO] Results:
[INFO] 
[ERROR] Errors: 
[ERROR]   HttpGetterTest.ignoreInvalidSsl:225 » ConnectTimeout Connect to https://localhost:45819 [localhost/127.0.0.1] failed: Read timed out
[INFO] 
[ERROR] Tests run: 65, Failures: 0, Errors: 1, Skipped: 0
[INFO] 
[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for CommaFeed 5.0.0:
[INFO] 
[INFO] CommaFeed .......................................... SUCCESS [  0.120 s]
[INFO] CommaFeed Client ................................... SUCCESS [05:24 min]
[INFO] CommaFeed Server ................................... FAILURE [01:08 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  06:35 min
[INFO] Finished at: 2024-08-18T11:18:52+02:00
[INFO] ------------------------------------------------------------------------
[ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:3.3.1:test (default-test) on project commafeed-server: 
[ERROR]

Skipping the tests is sufficient to end the build.

Athou · 2024-08-18T09:43:58Z

Not sure, but there is now a SSL handshake timeout on the HTTP client that was not set on previous versions. During tests, it's set to 5s which could be too low if you're building on a slow machine (MockServer is building a SSL certificate dynamically when needed, it takes 1.5s on my machine). Could you try to increase the timeout in line Mockito.when(config.httpClient().sslHandshakeTimeout()).thenReturn(Duration.ofSeconds(5)); of com.commafeed.backend.HttpGetterTest.java to something like 30s?

canoine · 2024-08-18T10:04:25Z

Indeed, my server is a slow machine :

[INFO] Running com.commafeed.backend.HttpGetterTest
Handler org.mockserver.logging.StandardOutConsoleHandler is not defined
Handler org.mockserver.logging.StandardOutConsoleHandler is not defined
OpenJDK 64-Bit Server VM warning: Sharing is only supported for boot loader classes because bootstrap classpath has been appended
2024-08-18 12:00:57,213 INFO  [io.net.uti.int.NativeLibraryLoader] (MockServer-MockServer-workerEventLoop9) /tmp/libnetty_tcnative_linux_x86_645656822277209167061.so exists but cannot be executed even when execute permissions set; check volume for "noexec" flag; use -Dio.netty.native.workdir=[path] to set native working directory separately.
[INFO] Tests run: 19, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 17.02 s -- in com.commafeed.backend.HttpGetterTest

The build is OK :

[INFO] ------------------------------------------------------------------------
[INFO] Reactor Summary for CommaFeed 5.0.0:
[INFO] 
[INFO] CommaFeed .......................................... SUCCESS [  0.112 s]
[INFO] CommaFeed Client ................................... SUCCESS [01:58 min]
[INFO] CommaFeed Server ................................... SUCCESS [01:19 min]
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time:  03:19 min
[INFO] Finished at: 2024-08-18T12:01:23+02:00
[INFO] ------------------------------------------------------------------------

Athou · 2024-08-18T10:26:10Z

Thanks! b88e5d2

canoine · 2024-08-18T10:34:49Z

Works well now. Thank you.

canoine · 2024-08-18T13:57:42Z

Dumb question, but perhaps useful for other sysadmins : could you be more precise about the application.properties location, and its syntax, please ? I tried several directories, and commafeed always ignores it. So I use an .env file, successfully.
Perhaps you could add an example into the tree ?

Athou · 2024-08-18T15:04:56Z

I guess you tried to configure the JDBC url and it didn't work, because I just tried and it was not working for me either, until I realized I made a mistake in the README e6dd088 I'm sorry 😢

It worked with the .env because both . and - should be _ in env variables.

canoine · 2024-08-18T15:21:01Z

OK, no problem. Let's try. :)
Another question : is there an equivalent to "publicUrl:" (config.yml) for an instance behind a reverse proxy ?

Athou · 2024-08-18T15:29:22Z

It's not needed anymore, the value was only used in contexts where the HTTP request was available so now it's extracted from the request. Your reverse proxy needs to forward the hostname though, I think via the Host header. Caddy does this automatically, you have to configure it manually for nginx and httpd.

canoine · 2024-08-18T15:47:33Z

OK for application.properties. Thank you. The config directory must be in the same place than quarkus-run.jar.

Concerning the reverse proxy trick, nginx does it by defaut. Indeed, all seems to work well... All but the redirection to the login page after disconnection, where there's no URL rewriting.

Athou · 2024-08-18T15:54:56Z

I think you need those two nginx directives for it to work:

proxy_set_header Host $host;
proxy_set_header X_FORWARDED_PROTO https;

canoine · 2024-08-18T16:05:49Z

Oh yes ! I inadvertently deleted the second directive during a config update, it seems. Sorry, that works.

Athou · 2024-08-18T19:20:56Z

I just added a link to this in the README https://github.com/Athou/commafeed/blob/master/commafeed-server/doc/commafeed.adoc It's not very sexy yet but it should help.

canoine · 2024-08-18T22:41:36Z

Nice ! That's much more understandable. Thank you.

Athou added 30 commits August 13, 2024 12:48

WIP

cc32f8a

restore Docker workflow

09e0a51

merge docker amd64 and arm64 tags

1fd48a0

use quarkus mailer for password recovery

aaf237d

use profile instead of system property to set db-kind

6b0aa32

set a Max-Age on the auth cookie

8940500

remove unused timers page

04af355

fix opml import encoding issue

78a5267

add release ci job

dc16e43

add windows builds

f7adef0

TODO remove redis

3af8485

remove redis as caching is no longer needed now

0446944

README update

21ce9db

ci for quarkus branch

9a43fd4

use a relative link

aabbf0a

javadoc tweaks

3b56496

README tweaks

77b6cf7

fix warning in native mode about parser not found

f2c6734

rome needs to clone Date in native mode

a92df77

README tweaks

857736a

only use rest-assured for tests

69cd90e

prepare 5.0.0 changelog

e170dfe

resolve public url dynamically, remove publicUrl config element

d612d83

config comment tweaks

e757e61

generate jvm package with a -jvm suffix

c18ed82

use Duration for query timeout

47d3983

remove STARTUP_TIME because static fields are initialized at compile …

815093f

…time in native mode

timeout should be an Integer

643954f

mute MediaModuleParser warnings

da910ac

add missing rome classes

2f51547

Athou added 13 commits August 16, 2024 14:23

README tweaks

ab6457e

set a timeout on ssl handshakes

b333e8d

use join to speed up cleanup

5b77860

keep using the same css parser as before

1b1a3f4

configurable http client timeouts

012ce71

no need to start a transaction to fetch favicons

e7748d7

add ResourceBundle needed for cssparser in native image

2395a26

try to fix "Illegal attempt to associate a ManagedEntity with two ope…

e38ca66

…n persistence contexts"

javadoc tweaks

9218f19

README tweaks

c577e77

increase timeout a little bit because github actions are laggy

c4c41d1

version dockerhub readme and update it automatically on release

3627ee3

configurable filtering expression evaluation timeout

ede7834

Athou changed the title ~~Migrate to QUarkus~~ Migrate to Quarkus Aug 18, 2024

Athou merged commit 8594908 into master Aug 18, 2024
9 checks passed

Athou deleted the quarkus branch August 18, 2024 05:54

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate to Quarkus #1520

Migrate to Quarkus #1520

Athou commented Aug 18, 2024

canoine commented Aug 18, 2024 •

edited

Loading

Athou commented Aug 18, 2024

canoine commented Aug 18, 2024

Athou commented Aug 18, 2024

canoine commented Aug 18, 2024

canoine commented Aug 18, 2024

Athou commented Aug 18, 2024 •

edited

Loading

canoine commented Aug 18, 2024

Athou commented Aug 18, 2024

canoine commented Aug 18, 2024

Athou commented Aug 18, 2024

canoine commented Aug 18, 2024

Athou commented Aug 18, 2024

canoine commented Aug 18, 2024

Migrate to Quarkus #1520

Migrate to Quarkus #1520

Conversation

Athou commented Aug 18, 2024

canoine commented Aug 18, 2024 • edited Loading

Athou commented Aug 18, 2024

canoine commented Aug 18, 2024

Athou commented Aug 18, 2024

canoine commented Aug 18, 2024

canoine commented Aug 18, 2024

Athou commented Aug 18, 2024 • edited Loading

canoine commented Aug 18, 2024

Athou commented Aug 18, 2024

canoine commented Aug 18, 2024

Athou commented Aug 18, 2024

canoine commented Aug 18, 2024

Athou commented Aug 18, 2024

canoine commented Aug 18, 2024

canoine commented Aug 18, 2024 •

edited

Loading

Athou commented Aug 18, 2024 •

edited

Loading