Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add confirmation dialog when we delete a subscriber of Bioscurity #324

Open
qifeng-bai opened this issue Nov 4, 2024 · 2 comments
Open
Assignees
Milestone

Comments

@qifeng-bai
Copy link
Contributor

qifeng-bai commented Nov 4, 2024

Where if you try to copy and paste an email address of a subscriber, it detects any mouse event on it and deletes that subscriber. It needs a confirmation to say “Are you sure you want to remove this email address…

Also added: Only clicking the delete icon will trigger the deletion.

@nickdos nickdos removed their assignment Nov 5, 2024
@nickdos
Copy link
Contributor

nickdos commented Nov 5, 2024

When you "hover" over the delete icon, there is no "feedback" to indicate the icon is a clickable element. I.e. the mouse icon remains an"arrow" and not the expected "hand" (pointer) cursor. See

<i onclick="unsubscribe(268, 142,'nick.dosremedios@csiro.au')" class="fas fa-trash"></i>

This should be changed to either a <a href=... or <button... element so that the user is clear that the element is "clickable".

@qifeng-bai
Copy link
Contributor Author

Added a hand pointer for all clickable items

@qifeng-bai qifeng-bai added this to the 4.4.0 milestone Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants