Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional and empty services #103

Conversation

vjrj
Copy link
Contributor

@vjrj vjrj commented Dec 17, 2020

Currently the dashboard only works when all queries returns values and all the ALA services are working as expected. This PR:

I've tested with:

  • ALA services (double checking that I don't break nothing with this PR in the ALA production dashboard, attached my properties).
  • An empty LA new deployment
  • And now that I can generate inventories and /data directories easily, I also tested with Canadensys, Sweden and Vermont portals.

ALA-dashboard-config.properties.txt

@vjrj vjrj requested a review from ansell December 17, 2020 21:32
@ansell ansell removed their request for review January 6, 2021 09:00
Copy link
Contributor

@ansell ansell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping the ala-bootstrap3 plugin version is the main change I can see.

build.gradle Outdated Show resolved Hide resolved
grails-app/conf/application.yml Show resolved Hide resolved
@vjrj vjrj requested a review from ansell January 20, 2021 07:34
@vjrj
Copy link
Contributor Author

vjrj commented Jan 20, 2021

Tested locally again with ALA services, and works well to me.

2021-08-20-08-25-21-screenshot

@vjrj
Copy link
Contributor Author

vjrj commented Jan 26, 2021

@nickdos or @djtfmartin Can you have a look of this PR? I've tested a lot with different portals.
There are people in the community waiting for this. Thanks!

Related: https://atlaslivingaustralia.slack.com/archives/CCTFGEU1G/p1608241694318900

@djtfmartin djtfmartin requested review from djtfmartin and removed request for ansell January 26, 2021 13:47
Copy link
Member

@djtfmartin djtfmartin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@djtfmartin djtfmartin merged commit 9154cda into AtlasOfLivingAustralia:master Jan 26, 2021
@vjrj
Copy link
Contributor Author

vjrj commented Jan 26, 2021

@vjrj
Copy link
Contributor Author

vjrj commented Jan 26, 2021

Ok, a new build of the dashboard is now nexus. Great, we'll use in short...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants