Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/grails5 #120

Merged
merged 9 commits into from
May 2, 2023
Merged

Feature/grails5 #120

merged 9 commits into from
May 2, 2023

Conversation

sughics
Copy link
Contributor

@sughics sughics commented Mar 30, 2023

PR for #119

@sughics sughics requested a review from sbearcsiro May 1, 2023 07:45
Copy link

@sbearcsiro sbearcsiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - just looks like Constants.WebServices had def grailsApplication accidentally added.

/**
* Created by rui008 on 26/11/2014.
*/
class Constants {

class WebServices {

def grailsApplication

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated

build.gradle Outdated
}


version "2.4"
version "2.4.1-SNAPSHOT"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably bump the minor or major version.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed. Will bump up the minor version 2.5.0 as I've done with some other apps

Copy link

@sbearcsiro sbearcsiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sughics sughics merged commit fb80825 into master May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants