-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should there be a galah_profile
function?
#130
Labels
enhancement
New feature or request
Comments
Proposed name change to something more informative, e.g. |
mjwestgate
added a commit
that referenced
this issue
Feb 8, 2022
This works ok, but requires further testing. Name may change in later versions. Also a deprecation message is needed for users who use the `profile` argument of `galah_filter` from now on.
daxkellie
added a commit
that referenced
this issue
Sep 5, 2022
* Naming changed to remain consistent with verbing language of `galah_` functions
A decision was made after discussion to make the name |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Currently, users set a profile as an optional argument within
galah_filter
. This is weird for a few reasons:tibble
; instead the profile name is added as an attribute, which is not standard behavior for any othergalah_
functionshow_all_profiles
), but no correspondinggalah_
functiongalah_filter
is awkward because it doesn't use NSE. In practice, this results in combining calls that use=
and==
within the same function (e.g.galah_filter(year == 2020, profile = "ALA")
), which is confusingAlternate behaviour would be to allow piping of profiles specifically through its' own function, such as:
The text was updated successfully, but these errors were encountered: