menu-config internationalization #428

biodivAtlasAT · 2021-10-27T16:15:06Z

Dear community,

I tried to do internationalization to the menu-config.json
by adding i18nNr variable refering to the message.properties numbers of spatial-hub

I changed menuServcie.js when menu data is loaded to:

if ($SH.menu.indexOf('http') == 0) {
var setup = $http.get($SH.menu, _httpDescription('getMenu')).then(function (data) {
var it_0 = 0;
var it_1 = 0;
for(it_0 = 0; it_0 < data.data.length; it_0++) {
data.data[it_0].name = $i18n(data.data[it_0].i18nNr);
for(it_1 = 0; it_1 < data.data[it_0].items.length; it_1++) {
data.data[it_0].items[it_1].name = $i18n(data.data[it_0].items[it_1].i18nNr);
}
}
menuConfig = data.data;
return menuConfig;
});
} else {
menuConfig = $SH.menu;
setup = $q.when(menuConfig)
}

Excuse me, but there are other unneeded changes in this too - I applied a window.getCookie('lang') for switching language
all over the atlas which won't be needed by all of us

We added the String names of the menu-config.json file into our message.properties within incemented numbers

best regards
Georg Neubauer

ace.js npm path

# Conflicts: # grails-app/assets/javascripts/spApp/service/i18nService.js # grails-app/i18n/messages_de.properties

_Events.groovy def p = new File(baseDir + '/grails-app/i18n/messages.properties') // test refere to data dir //def p = new File('/data/spatial-hub/i18n/messages.properties')

toDo spatial service on linux language to complete!

within using the message.properties numbers as variables in addition to menu-config.json "name": "Name" "i18nNr": "number"

vjrj · 2021-10-29T07:53:24Z

_Events.groovy

    println 'Starting NPM install'
    final workdir = new File(baseDir, '')
    final proc = new ProcessBuilder().inheritIO()
-    final exec = proc.command('npm', '-dd', 'install').start()
+    // npm for UNIX, npm.cmd for Windows
+    final exec = proc.command('npm.cmd', '-dd', 'install').start()


I see several problems in the PR. This is not related with menu-config internationalization. Please send a PR for this npm issue ensuring that your change doesn't affect others.

If we merge this, will only work in Windows (not as before).

So find a solution that works for Windows and Linux/Mac systems (detecting the platform or similar).

With a PR using upstream code with only this change, will be easy to review and merge. The same with others changes.

qifeng-bai

I saw run.cmd has been fixed. Shall we only cherry-pick internationalisation part or merge all? @vjrj

qifeng-bai · 2021-11-01T03:33:55Z

grails-app/assets/javascripts/spApp/service/toolAddFacetService.js

@@ -25,22 +25,22 @@
                            }
                        },
                        {
-                            "description": "Species options.",
+                            "description": $i18n(411),


Shall we add a default value, like: $i18n(411, "Species options."). It would give developers a direct hint : it is "Species options.".

I have added a new $i18n(k, v) method to support this functionality

biodivAtlasAT · 2021-11-02T08:26:39Z

Hello, yes I think so! If the default value is the english descriptive name it will be easier to match the descriptive names of the other languages and we wouldn’t have to match them over the numbers. Do you agree? best regards Georg Von: QBai ***@***.***> Gesendet: Montag, 1. November 2021 04:34 An: AtlasOfLivingAustralia/spatial-hub ***@***.***> Cc: Georg Neubauer ***@***.***>; Author ***@***.***> Betreff: Re: [AtlasOfLivingAustralia/spatial-hub] menu-config internationalization (PR #428) @qifeng-bai commented on this pull request.

________________________________ In grails-app/assets/javascripts/spApp/service/toolAddFacetService.js<#428 (comment)>:

@@ -25,22 +25,22 @@

} }, { - "description": "Species options.", + "description": $i18n(411), Shall we use a default value, like: $i18n(411, "Species options."). It would give developers a direct hint : it is "Species options." — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#428 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANPMCUG4CHJD3EDKLFYKFHLUJYDC7ANCNFSM5G2X72IQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

qifeng-bai · 2021-11-03T00:11:23Z

o! If the default value is the english descriptive name it will be easier to match the descriptive names of the other languages and we wouldn’t have to match them over the numbers.

Yes, we agree.

At this moment, we use both ways, since historically grails i18n pipeline plugin automatically generates i18n key-value pair by using number as key.

Please check our latest commits (i18n) in our dev branch. What we changed:

Add a new function $i18n = function (k, v) in spApp.js . Add a new parameter v, if cannot find key in i18n properties, use V as default. - also, it can be a hint when the key is a number. for example :
$i18n(411, "Species options.").
if 411 cannot be found, use "Species options."

In menuService.js, we merged your code for dynamic menu with small changes -> using name as key, not your i18nNr

In message.properties, we added few examples of 'descriptive names' as key
Add\ to\ map=Add to map

we also support $i18n("Add to map")

If 'Add to map' cannot be found in message.properties, it will use 'Add to map' as value

Cheers

biodivAtlasAT · 2021-11-03T07:31:36Z

Hello, that sounds perfect! thanks for the task! Cheers

…

________________________________ Von: QBai ***@***.***> Gesendet: Mittwoch, 3. November 2021 01:11 An: AtlasOfLivingAustralia/spatial-hub ***@***.***> Cc: Georg Neubauer ***@***.***>; Author ***@***.***> Betreff: Re: [AtlasOfLivingAustralia/spatial-hub] menu-config internationalization (PR #428) o! If the default value is the english descriptive name it will be easier to match the descriptive names of the other languages and we wouldn’t have to match them over the numbers. Yes, we agree. At this moment, we use both ways, since historically grails i18n pipeline plugin automatically generates i18n key-value pair by using number as key. Please check our latest commits (i18n) in our dev branch. What we changed: Add a new function $i18n = function (k, v) in spApp.js . Add a new parameter v, if cannot find key in i18n properties, use V as default. - also, it can be a hit when the key is a number. for example : $i18n(411, "Species options."). In menuService.js, we merged your code for dynamic menu with small changes -> using name as key, not your i18nNr In message.properties, we added few examples of 'descriptive names' as key Add\ to\ map=Add to map Cheers — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#428 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANPMCUFWAFNXZV4BQVUVY2DUKB43LANCNFSM5G2X72IQ>. Triage notifications on the go with GitHub Mobile for iOS<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

vjrj · 2022-01-19T17:16:30Z

I saw run.cmd has been fixed. Shall we only cherry-pick internationalisation part or merge all? @vjrj

Sincerely, I still see a mix of things here, and I see difficult to cherry-pick, but it's my impression. Also other minor things should be addressed like:

qifeng-bai · 2022-01-20T21:50:51Z

Thanks, @vjrj . I will follow up it after I finish my current tasks

Reinhardt and others added 11 commits April 9, 2020 09:17

UTF-8 Encoding for POST-Requests

e7e4c02

apply language switch test

f45ea51

apply language switch test

f881fe8

apply language switch test

641f669

ace.js npm path

i18n test rollback

6c4b79d

i18n progress 01

8cd654e

Merge remote-tracking branch 'origin/master'

2fd2999

# Conflicts: # grails-app/assets/javascripts/spApp/service/i18nService.js # grails-app/i18n/messages_de.properties

i18n progress 02

44b813f

_Events.groovy def p = new File(baseDir + '/grails-app/i18n/messages.properties') // test refere to data dir //def p = new File('/data/spatial-hub/i18n/messages.properties')

commit funktion for i18nService rollback

d998090

added language switch to menu-config

d767d42

toDo spatial service on linux language to complete!

i18n for all languages

49a9319

within using the message.properties numbers as variables in addition to menu-config.json "name": "Name" "i18nNr": "number"

nickdos requested a review from qifeng-bai October 28, 2021 22:39

qifeng-bai approved these changes Oct 28, 2021

View reviewed changes

vjrj requested changes Oct 29, 2021

View reviewed changes

detecting OS for npm issue

7e3d986

qifeng-bai requested changes Oct 31, 2021

View reviewed changes

qifeng-bai self-requested a review October 31, 2021 22:15

qifeng-bai reviewed Nov 1, 2021

View reviewed changes

qifeng-bai added a commit that referenced this pull request Nov 1, 2021

#428 impl(i18n on dynamic menu)

4963c46

qifeng-bai added a commit that referenced this pull request Nov 5, 2021

#428 fix(i18n key)

1adb94e

qifeng-bai added a commit that referenced this pull request Nov 5, 2021

#428 fix(i18n key)

ffd506d

qifeng-bai mentioned this pull request Feb 18, 2022

Fix i18n issues #433

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

menu-config internationalization #428

menu-config internationalization #428

biodivAtlasAT commented Oct 27, 2021 •

edited

Loading

vjrj Oct 29, 2021

qifeng-bai left a comment •

edited

Loading

qifeng-bai Nov 1, 2021 •

edited

Loading

biodivAtlasAT commented Nov 2, 2021 via email

qifeng-bai commented Nov 3, 2021 •

edited

Loading

biodivAtlasAT commented Nov 3, 2021 via email

vjrj commented Jan 19, 2022

qifeng-bai commented Jan 20, 2022

menu-config internationalization #428

Are you sure you want to change the base?

menu-config internationalization #428

Conversation

biodivAtlasAT commented Oct 27, 2021 • edited Loading

vjrj Oct 29, 2021

Choose a reason for hiding this comment

qifeng-bai left a comment • edited Loading

Choose a reason for hiding this comment

qifeng-bai Nov 1, 2021 • edited Loading

Choose a reason for hiding this comment

biodivAtlasAT commented Nov 2, 2021 via email

qifeng-bai commented Nov 3, 2021 • edited Loading

biodivAtlasAT commented Nov 3, 2021 via email

vjrj commented Jan 19, 2022

qifeng-bai commented Jan 20, 2022

biodivAtlasAT commented Oct 27, 2021 •

edited

Loading

qifeng-bai left a comment •

edited

Loading

qifeng-bai Nov 1, 2021 •

edited

Loading

qifeng-bai commented Nov 3, 2021 •

edited

Loading