-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge of UI & service CICD infrastructure and pipelines #114
base: feature/cicd-pipeline
Are you sure you want to change the base?
Conversation
… the connection string
Nice work on the merge. I like having the app client as it's own standalone CF template, or more accurately of all the options I dislike it the least! :D CF feels more stable than CLI in managing resources as far as lifecycle and also seeing what's under management, it's nice not to have to shuffle nested stacks around from the cognito repo and reference them too. as far as shuffling some of the resources between components, I think it's good to be flexible and put them wherever fits best. It's gong to work either way but I reckon the DB should be it's own component still, it's something that we'd launch once and then only relaunch/update very infrequently. The deploy component is something that will launch a lot more often, if the DB is part of that it will slow the deploy down, I guess not that much if there's no updates but it just seems unnecessary as it will still have to check every time. With the secrets being in the DB stack there are other secrets like oidc-secrets that make it more of a common resource |
lists-service/cicd
&lists-ui/cicd
into a common rootcicd
directory.db-password
secrets manager into database CF template