Server side validation for restricted values #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jack-brinkman
changed the title
jack-brinkman
added
enhancement
adam-collins
requested changes
Apr 19, 2024
lists-service/src/main/java/au/org/ala/listsapi/service/ConstraintService.java
Outdated
Show resolved
Hide resolved
… for GraphQL controller
There was a problem hiding this comment.
I have a general issue with the introduction of a region constraint, as implied by existing code, the issues raised, and these changes. I think it is a bit of a mess and the simplest solution is to remove this new requirement that region is mandatory. This would simplify implementation, better support use outside of the ALA, simplify data migration, simplify alterations to the region definition list.
lists-service/src/main/java/au/org/ala/listsapi/service/ValidationService.java
Show resolved
Hide resolved
lists-service/src/main/java/au/org/ala/listsapi/service/ValidationService.java
Show resolved
Hide resolved
lists-service/src/main/java/au/org/ala/listsapi/service/ValidationService.java
Outdated
Show resolved
Hide resolved
| public class UtilsController { | ||
| @Autowired protected ValidationService validationService; | ||
|
|
||
| @Operation(tags = "REST", summary = "Get all constraint lists") |
There was a problem hiding this comment.
The openapi annotations could be more detailed. I'll leave this as optional as the same can be said for the other services.
lists-service/src/main/java/au/org/ala/listsapi/service/ValidationService.java
Outdated
Show resolved
Hide resolved
lists-service/src/main/java/au/org/ala/listsapi/service/ValidationService.java
Outdated
Show resolved
Hide resolved
This was referenced Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service Changes
lists,licenses,regions)UI Changes
contraints.json) for parity with the REST endpoint