-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Server side validation for restricted values #93
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The validation needs to be included in the graphQL controller as well.
lists-service/src/main/java/au/org/ala/listsapi/service/ConstraintService.java
Outdated
Show resolved
Hide resolved
… for GraphQL controller
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a general issue with the introduction of a region constraint, as implied by existing code, the issues raised, and these changes. I think it is a bit of a mess and the simplest solution is to remove this new requirement that region is mandatory. This would simplify implementation, better support use outside of the ALA, simplify data migration, simplify alterations to the region definition list.
lists-service/src/main/java/au/org/ala/listsapi/service/ValidationService.java
Show resolved
Hide resolved
lists-service/src/main/java/au/org/ala/listsapi/service/ValidationService.java
Show resolved
Hide resolved
lists-service/src/main/java/au/org/ala/listsapi/service/ValidationService.java
Outdated
Show resolved
Hide resolved
public class UtilsController { | ||
@Autowired protected ValidationService validationService; | ||
|
||
@Operation(tags = "REST", summary = "Get all constraint lists") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The openapi annotations could be more detailed. I'll leave this as optional as the same can be said for the other services.
Service Changes
lists
,licenses
,regions
)UI Changes
contraints.json
) for parity with the REST endpoint