Set cookies from underlying Netty request on AtmosphereRequest #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfarcand
added a commit
that referenced
this pull request
Jun 3, 2013
Set cookies from underlying Netty request on AtmosphereRequest
|
Wow thanks a lot! Much easier that way! |
|
Atmosphere Framework » nettosphere #151 SUCCESS |
jfarcand
added a commit
to Atmosphere/atmosphere
that referenced
this pull request
Sep 10, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed access to the request cookies in onSuspend when using Nettosphere. Granted, the cookie header is available via getHeader, completely understand if I should just parse the Cookie header in my app instead of having them available via getCookies on the AtmosphereRequest.
Or I might be missing another way to get at them...very new to this code.
Either way, thanks for Atmosphere!