Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Asyncify the specs #74

Closed
wants to merge 3 commits into from
Closed

Asyncify the specs #74

wants to merge 3 commits into from

Conversation

Arcanemagus
Copy link
Member

Bring in jasmine-fix to allow the use of async/await in the specs and refactor them to take advantage of this.

Bring in `jasmine-fix` to allow the use of `async`/`await` in the specs
and refactor them to take advantage of this.
@Arcanemagus Arcanemagus force-pushed the arcanemagus/asyncify-specs branch 2 times, most recently from 23a36a7 to 7691fe4 Compare September 8, 2017 22:10
@Arcanemagus
Copy link
Member Author

Arcanemagus commented Sep 8, 2017

This being impossible to debug on Windows makes this very difficult to work on.... as far as I can tell from the debug statements codeclimate is somehow taking over 10 seconds to return, so the specs just give up on it and fail.

@Arcanemagus Arcanemagus force-pushed the arcanemagus/asyncify-specs branch from 7691fe4 to b7305e4 Compare September 8, 2017 22:48
@Arcanemagus
Copy link
Member Author

As there isn't really much point in bringing this in for just the beforeEach block, and it looks like the actual test can't be (easily) run with async, I'm just going to close this PR for now.

@Arcanemagus Arcanemagus closed this Sep 8, 2017
@Arcanemagus Arcanemagus deleted the arcanemagus/asyncify-specs branch September 8, 2017 22:56
@Arcanemagus Arcanemagus restored the arcanemagus/asyncify-specs branch September 21, 2017 22:03
@Arcanemagus Arcanemagus reopened this Sep 21, 2017
`jasmine-fix@1.3.1` sets the global timeout in a much saner way,
allowing us to easily override it here.
@Arcanemagus Arcanemagus force-pushed the arcanemagus/asyncify-specs branch 2 times, most recently from 83293aa to d3ba0be Compare September 21, 2017 22:55
@Arcanemagus Arcanemagus force-pushed the arcanemagus/asyncify-specs branch from d3ba0be to b4a973c Compare September 21, 2017 23:08
@Arcanemagus
Copy link
Member Author

Anyone that's able to run this locally want to check on why this isn't working? The CI build isn't even printing the debug text...

@cgalvarez
Copy link
Contributor

cgalvarez commented Feb 26, 2018

I'm currently having problems with the tests on #83 , so I'm trying to fix them with your approach here.

@Arcanemagus I cannot get your debug messages printed too, so I've used another approach: writing a log file. I've checked that in my case, I'm getting messages = null, so I suspect that's what happening to you here, and that's why the CI build fails with TypeError: Cannot read property 'length' of null.

Keep on digging into this, but any help would be greatly appreciated 😉

@cgalvarez
Copy link
Contributor

Finally got to understand this weird behavior.

When running specs, no timeout is provided to Helpers.exec(...), so after the @Arcanemagus ' mythical 10s 😛 the cli is killed and null is returned.

I'm fixing this issue in #83 too, since I need it to get tests passing.

@cgalvarez cgalvarez mentioned this pull request Feb 26, 2018
6 tasks
@Arcanemagus Arcanemagus deleted the arcanemagus/asyncify-specs branch April 21, 2018 05:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants