This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Filters and tidy #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Omegaice, looks good! I'll give it a test. |
|
Passed testing 👍 |
Nathan-Smith
added a commit
that referenced
this pull request
Jun 3, 2014
Filters and tidy. * Removed dependancy on node module * Added ability to manage cpplint filters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I installed this linter module and realized its warned about too many things that I did not want, so I started to mess with the code to add filters into it.
I had some issues passing the filters on the command line to the node module and then realized that the node module was a wrapper for the python file. I removed the module as a dependance and just kept the python executable as it seemed cleaner and should reduce the download and install time.
The output parsing was the same for the node module and the base executable which simplified things. I then changed the regex to remove the verbosity level as it was information that didn't seem useful at the moment as there is no way to set the verbosity.