Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Revert isNodeExecutable: yes #14

Merged
merged 3 commits into from
Jun 27, 2015
Merged

Revert isNodeExecutable: yes #14

merged 3 commits into from
Jun 27, 2015

Conversation

arturparkhisenko
Copy link
Contributor

No description provided.

Arthur Parkhisenko and others added 3 commits December 3, 2014 20:03
@arturparkhisenko
Copy link
Contributor Author

ex path its when i see last csslint commit :D

@druellan
Copy link

Just to point out that on Atom 0.183 and CSSLINT 0.0.11, I need this patch to get it working on Windows 8.1

@rustamli
Copy link

Guys please merge this one, otherwise it doesn't work on Windows. Had to spend sometime before I figured out that it wasn't working because of isNodeExecutable

@arturparkhisenko
Copy link
Contributor Author

@AsaAyers @dhagerty9009 @relekang @k2b6s9j someone pls..

@keplersj
Copy link
Contributor

I have no pulling power here. You're looking for @hd-demam probably.

@keplersj
Copy link
Contributor

/cc @hd-deman

Damn GitHub mobile.

@arturparkhisenko
Copy link
Contributor Author

@k2b6s9j thank you 👍

@keplersj
Copy link
Contributor

@ikeagold You're quite welcome.

This was referenced May 17, 2015
@Arcanemagus
Copy link
Member

@hd-deman, @kevinsawicki, @zimme, @pborreli:
Can anyone merge this PR so this plugin works properly without modification?

@ansballard
Copy link

👍

@corintho
Copy link

After making this change on my local installation, I was able to have it properly running in windows. So, a +1 to the fix. And a thank you for ikeagold for spotting the issue and opening the pull request for all of us.

keplersj added a commit that referenced this pull request Jun 27, 2015
Revert isNodeExecutable: yes
@keplersj keplersj merged commit 9e2a516 into AtomLinter:master Jun 27, 2015
@keplersj
Copy link
Contributor

So the real solution here isn't to revert isNodeExecutable, it's for this linter to be rewritten for the new Linter 1.0 API. I'll merge this in for now since so many of you are claiming success but this linter is on my queue for linters which absolutely need a rewrite.

@keplersj
Copy link
Contributor

This change has been published in v0.0.14

@arturparkhisenko
Copy link
Contributor Author

@k2b6s9j :) this is must be a best code n text editor in a world!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants