Update to the new Linter API #33
Conversation
|
Specifically, line/column numbers are not showing up in messages. |
|
Line/Column are only hidden when you don't provide the |
| executablePath: | ||
| title: 'CSSLint Executable Path' | ||
| type: 'string' | ||
| # default: path.join(__dirname, '..', 'node_modules', '.bin', 'csslint.cmd') |
There was a problem hiding this comment.
If it's available as an npm module, I highly recommend we use that!
There was a problem hiding this comment.
How would I include it? As far as I could tell it doesn't provide the "cli wrapper mode" that things like jshint do.
There was a problem hiding this comment.
You could use the execNode method of the helpers module and pass in the direct .js path to it (Note: I am not sure if cmd one will work)
There was a problem hiding this comment.
On that note, currently on both my systems I had to manually specify the path, since even if you point it at the bundled directory it's not smart enough to use PATHEXT.
I'll look into whether cli.js can be used.
|
Ah, knew I was forgetting something, I'll fix that in a sec. |
| range: [[line, char], [line, char]] | ||
| }] | ||
| }) | ||
| return toReturn |
Add filePath and offset character by one to the left.
|
Looks Good, except that I have a question, if |
|
Haven't had a chance to get that working yet, should have time tonight. |
|
So update time: So we can use the command line version above (after fixing path detection, since it currently has issues), but will not have lintOnSave functionality... or we can build something to read in the I'm leaning towards the latter as it offers more flexibility in the long run, so I'll commit what is done so far and can implement a |
Pulls in the `csslint` code and utilizes it directly. Unfortunately this means we need to pull in and parse the `.csslintrc` files ourselves. Linting on the fly can be enabled however.
Adds support for a .csslintrc file in the same directory as the file being linted.
|
Sorry this took so long, here is a version that supports pulling in options from a It seems this functionality is poorly documented at best in the CSSLint project, as some other linters based on it search in the user's home directory as well. Also the CSSLint project only documents supporting options in the same format as the command line options, yet everything (including CSSLint!) supports a JSON format. Currently this only supports the JSON format for |
Move to the AtomLinter/csslint for until `stdin` and `JSON` support are implemented in the main repository. Use helpers.execNode to run the linter.
|
Okay, utilizing the Any further issues? |
|
I'll test it as soon as I have some time |
Update to the new Linter API
Updates to the new Linter API. Also moves to the XML output, enabling some more advanced information.
DO NOT MERGESome issues with the
Messageformat lead me to think this can be improved a bit before release, but I wanted to bring this out for review.