Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Handle messages with no line #38

Merged
merged 1 commit into from
Aug 6, 2015
Merged

Handle messages with no line #38

merged 1 commit into from
Aug 6, 2015

Conversation

Arcanemagus
Copy link
Member

@Arcanemagus Arcanemagus commented Aug 6, 2015 •
edited
Loading

csslint has "rollup" messages that have no line number associated with them. If such a message is encountered place it at the beginning of the file.

@Arcanemagus
Handle messages with no line
5f68f7e 
csslint has "rollup" messages that have no line number associated with
them. If such a message is encountered place it at the beginning of the
file.
@Arcanemagus
Copy link
Member Author

Fixes #37 and should fix steelbrain/linter#804 as well.

@steelbrain
Copy link
Contributor

Forgive me, I don't understand, if there's no rollup, the error is in the first line of the file?

@Arcanemagus
Copy link
Member Author

If there is no rollup, then there should be a line and col element in the message and we can use that. If rollup is present (and apparently true), then the message has no line or col elements.

@steelbrain
Copy link
Contributor

LGTM in that case.

steelbrain added a commit that referenced this pull request Aug 6, 2015
@steelbrain
Merge pull request #38 from Arcanemagus/fake-line-num
8d0d5b3 
Handle messages with no line
@steelbrain steelbrain merged commit 8d0d5b3 into AtomLinter:master Aug 6, 2015
@Arcanemagus
Copy link
Member Author

I suppose the conditional could have been flipped just as easily, that was just the way I thought about it 😉.

@Arcanemagus Arcanemagus deleted the fake-line-num branch August 6, 2015 21:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Arcanemagus @steelbrain