Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Don't make any assumptions about output #39

Merged
merged 1 commit into from
Aug 7, 2015
Merged

Don't make any assumptions about output #39

merged 1 commit into from
Aug 7, 2015

Conversation

Arcanemagus
Copy link
Member

@Arcanemagus Arcanemagus commented Aug 7, 2015

Don't assume the message has a line, column, or rule.

Don't assume the message has a line, column, or rule.
@Arcanemagus
Copy link
Member Author

As shown in the referenced issue, apparently csslint will output internal errors as "errors" on the file it is called on. This removes all but one assumption about the return. (If a error message has a message property, but no type this will have an issue).

@steelbrain
Copy link
Contributor

LGTM, test and merge at will.

@Arcanemagus
Copy link
Member Author

Works locally at least, merging:
image

Arcanemagus added a commit that referenced this pull request Aug 7, 2015
Don't make any assumptions about output
@Arcanemagus Arcanemagus merged commit 1322397 into AtomLinter:master Aug 7, 2015
@Arcanemagus Arcanemagus deleted the actually-fix branch August 7, 2015 08:45
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants