This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Add option to silence fixable rules while typing #1018
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an option that silences fixable rules while typing. The list of fixable rules is populated from ESLint itself, and only sent back to the main package code when it updates to reduce message size. This means that this will only start silencing rules after the first lint rule. Since a lint is triggered on open by default this _should_ be largely transparent to the user. Fixes #894.
Arcanemagus
force-pushed
the
arcanemagus/silence-fixable-rules
branch
from
ad77cc4 to
07b4781
Compare
|
Just found a major bug in this, and I'm expanding the tests to check for it. (This was silencing all rules due to some unfinished code, but the specs weren't showing this!) |
Add an expected message to the "ignore rule while editing" specs that stays constant, verifying that only the expected rules are being ignored.
Restrict the list of rules sent back as fixable rules to... the rules that are fixable, instead of _all_ rules.
Conflicts: src/helpers.js src/main.js
We need to use the instance of `linter` from `cliEngine`, so that the plugin rules are loaded.
IanVS
approved these changes
Sep 18, 2017
There was a problem hiding this comment.
I found that initially we were not getting a list of plugin rules, so those would not have been ignored. I pushed up a commit to use the internal linter instance that is attached to the cliEngine, which will have all of the plugin rules correctly loaded. It's not exactly a public property of CliEngine, but it should be pretty safe to use I believe.
Nice work, this will be a great option to have.
|
Thanks for fixing that up and the detailed testing @IanVS! ❤️ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an option that silences fixable rules while typing. The list of fixable rules is populated from ESLint itself, and only sent back to the main package code when it updates to reduce message size. This means that this will only start silencing rules after the first lint rule. Since a lint is triggered on open by default this should be largely transparent to the user.
Fixes #894.