-
Notifications
You must be signed in to change notification settings - Fork 141
restore cursor position after fix command #853
restore cursor position after fix command #853
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This code will not do what you are saying, since by definition the buffer will have changed so the position you save initially will no longer be the position after the fixes are applied.
That being said though... this will get close in most situations, and is better than what we have currently so I'd be okay with merging this in pending approval from @IanVS.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems reasonable. We can't consistently reproduce the buffer reset problem, so unfortunately we can't test that this actually has the intended effect. But it doesn't seem to hurt anything. The only request I would make is to add some comments to explain why this is being done. I don't think it's obvious by looking at the code why we would need to do this.
Thanks for the contribution, @yacut! |
@IanVS, could you please publish the changes? |
Actually, I've been using To do that, uninstall |
I already installed it from the master and it's works works for me: https://media.giphy.com/media/3o7bubhh3ZUgFe41qg/giphy.gif |
It usually works for me too, the cursor resetting is intermittent. Can you leave it on for several days and report back whether it never resets. It happens once or twice a day for me, usually. |
…ter-fix" This reverts commit 27d5570.
…ter-fix" This reverts commit 27d5570.
…ter-fix" This reverts commit 27d5570.
…ter-fix" This reverts commit 27d5570.
…ter-fix" This reverts commit 27d5570.
…ter-fix" This reverts commit 27d5570.
…ter-fix" This reverts commit 27d5570.
The cursor at the moment jumps to the beginning of the file after the fix command. It infuriates me :)