Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Implement specs #55

Closed
Arcanemagus opened this issue Jan 14, 2016 · 7 comments
Closed

Implement specs #55

Arcanemagus opened this issue Jan 14, 2016 · 7 comments
Assignees
Milestone

Comments

@Arcanemagus
Copy link
Member

It looks like this linter does not currently have any specs written for it, adding it to the list being maintained here for tracking.

Specs do not need to be super detailed, as they should mainly test whether the package is properly running the linter plugin and parsing its messages. Leave testing of the linter functionality to the author of the linter.

If you need any help feel free to ask!

@florianb florianb self-assigned this Jan 26, 2016
@florianb florianb modified the milestone: Release 1.6.0 Feb 9, 2016
@florianb florianb added wip and removed wip labels Feb 11, 2016
@florianb
Copy link
Contributor

Fundamental specs implemented.

The whole test-arrangement could be improved f.e. by mocking more the javac-dependency (see #70).

florianb pushed a commit to florianb/linter-javac that referenced this issue Feb 11, 2016
@Arcanemagus
Copy link
Member Author

Thanks!

@florianb
Copy link
Contributor

@Arcanemagus you're welcome - 👍 I'm merging it in with the upcoming release..

@florianb
Copy link
Contributor

@steelbrain - i am still working on the tests and i have a question (which i already posted on Slack), is there a way to obtain the linted messages from within a running atom-environment?

@steelbrain
Copy link
Contributor

Usually the way we test linter providers is,

linter = getProvider()
const results = await linter.lint(textEditor)
expect(results.length).toBe(1)
expect(results[0]).toEqual({type: 'Error', text: 'something', filePath: '/path/to/file'})

@florianb
Copy link
Contributor

Hmm, getProvider() is currently unavailable since i tried to not instantiate the linter on my own but use the instance created by atom. But i guess that's just not possible.

@florianb
Copy link
Contributor

Thanks anyways! I'm going to instantiate the linter again.. 🍬

@florianb florianb mentioned this issue Feb 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants