This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 17
Implement specs #55
Comments
Fundamental specs implemented. The whole test-arrangement could be improved f.e. by mocking more the |
florianb
pushed a commit
to florianb/linter-javac
that referenced
this issue
Feb 11, 2016
implemented AtomLinter#55
Thanks! |
@Arcanemagus you're welcome - 👍 I'm merging it in with the upcoming release.. |
@steelbrain - i am still working on the tests and i have a question (which i already posted on Slack), is there a way to obtain the linted messages from within a running atom-environment? |
Usually the way we test linter providers is, linter = getProvider()
const results = await linter.lint(textEditor)
expect(results.length).toBe(1)
expect(results[0]).toEqual({type: 'Error', text: 'something', filePath: '/path/to/file'}) |
Hmm, |
Thanks anyways! I'm going to instantiate the linter again.. 🍬 |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
It looks like this linter does not currently have any specs written for it, adding it to the list being maintained here for tracking.
Specs do not need to be super detailed, as they should mainly test whether the package is properly running the linter plugin and parsing its messages. Leave testing of the linter functionality to the author of the linter.
If you need any help feel free to ask!
The text was updated successfully, but these errors were encountered: