Add CirclCI, TravisCI, and Appveyor configs #14
Conversation
SpainTrain
commented
Dec 9, 2015
SpainTrain
commented
| on_failure: change | ||
| os: osx | ||
|
|
||
| script: apm install && npm tst |
There was a problem hiding this comment.
I'd put this as npm test, just to match the actual name in the package.json.
|
✅ |
|
The Travis script is out of date. The Atom team has published an updated one which supports OS X and Linux, testing on the Stable Atom and Beta Atom. |
|
@kepler0 The only real differences between the current one there and this is the addition of testing Linux on Travis-CI and the beta channel testing. Since CircleCI does Linux testing faster (and nicer looking), there really isn't much point in that, although the beta channel testing is nice. On the other hand the OS X builds take up to 2x as long as the Linux builds so there isn't much reason not to also test Linux on Travis 😛. |
| on_failure: change | ||
| os: osx | ||
|
|
||
| script: apm install && npm test |
There was a problem hiding this comment.
This is failing for a few different reasons, the primary being you never installed Atom 😛.
|
Ya, I am happy to use whatever travis script. I just copied this one from linter-eslint. Relatedly, with some automation around AtomLinter/Meta#7 we could apply such updates to all "subscribed" linter repos at once. |
|
Reviewed 3 of 4 files at r1, 1 of 1 files at r2. Comments from the review on Reviewable.io |
Add CirclCI, TravisCI, and Appveyor configs
