This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Optionally omit globals warning #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arcanemagus
suggested changes
Jan 10, 2017
| @@ -58,6 +59,7 @@ export default { | |||
|
|
|||
| const messages = []; | |||
| let match = parseRegex.exec(result); | |||
| let globalsOmitted = atom.config.get('linter-moonscript.omitGlobalCheck'); | |||
There was a problem hiding this comment.
Please observe this setting like this, there's no need to go through the complexity of determining what it is and what the current value is on every call 😉.
| text: match[2], | ||
| range: helpers.rangeFromLineNumber(textEditor, line), | ||
| }); | ||
| if (!globalRegex.test(match[2]) && !globalsOmitted) { |
There was a problem hiding this comment.
This should be ||.
As it currently stands, if match[2] contains accessing global it will always be ignored. If it doesn't contain accessing global then the globalsOmitted option being false lets it show up, but if somebody enabled it then all messages will be hidden.
| "omitGlobalCheck": { | ||
| "type": "boolean", | ||
| "default": false, | ||
| "description": "Omit \"accessing global\" warning." |
|
Sorry it took so long to get this reviewed! |
|
Published in v1.1.0 🎉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a simple config variable that makes linter ignore "accessing global" warnings. It would be very useful since
moonc -lhas no support for this.