This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Rewrite in ES2017 #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily just to force EoL to be LF in this repo for further commits.
Just testing whether it can handle a file with no issues, standard lint messages, and a file with a parse error.
Includes several fixes/updates, such as: * Rename the option to `executablePath` to match all the other linter providers * Move to a `configSchema` so Atom doesn't have to execute the code to know what the configuration options are * Utilize `activationHooks` so the package is only active when the language is being used * Automatically install `linter` and `language-moonscript`, ensuring a basic working "out of the box" * Utilize `rangeFromLineNumber` to generate cleaner ranges by default * Move to `atom-linter` for execution, bringing with it several fixes * Use ESLint for linting the code itself * Handle a race condition if the file is modified after the lint was triggered
|
Oh and for future reference, the new regex was tested here: https://regex101.com/r/gRk1IA/1 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite in ES2017
Includes several fixes/updates, such as:
executablePathto match all the other linter providersconfigSchemaso Atom doesn't have to execute the code to know what the configuration options areactivationHooksso the package is only active when the language is being usedlinterandlanguage-moonscript, ensuring a basic working "out of the box"rangeFromLineNumberto generate cleaner ranges by defaultatom-linterfor execution, bringing with it several fixesFixes #1.
Fixes #4.