Add specs #121
Add specs #121
Conversation
|
Oh wow, this one is still on CoffeeScript? 😞 Looking over this now. |
| @@ -0,0 +1,5 @@ | |||
| { | |||
| "max_line_length": { | |||
| "level": "ignore" | |||
There was a problem hiding this comment.
Normally I would say this should be 120 at most, but I plan on re-writing this in JS anyway so this is fine.
There was a problem hiding this comment.
Yeah, I agree. However, this linter has a couple of large lines and I did not want to add the specs and change the code at once. Would it be cool if I send another PR after this one gets merged to fix this?
spec/linter-pycodestyle-spec.js
Outdated
| 'use babel'; | ||
|
|
||
| import { join } from 'path'; | ||
| import { beforeEach, it } from 'jasmine-fix'; |
There was a problem hiding this comment.
Let's preemptively stop any accidental bizarreness later and make this:
// eslint-disable-next-line no-unused-vars
import { it, fit, wait, beforeEach, afterEach } from 'jasmine-fix';For example if you later try to focus a test that is async it will always show as passing when it really fails if you aren't importing the fit from jasmine-fix.
spec/linter-pycodestyle-spec.js
Outdated
| editor = await atom.workspace.open(badPath); | ||
| }); | ||
|
|
||
| it('finds at least one message', async () => { |
There was a problem hiding this comment.
🔥 I've been moving specs to just drop this one and check everything in the test after this.
There was a problem hiding this comment.
I see, if there isn't at least one message then the next test will fail anyway. done.
Implement specs and add lint. Fix AtomLinter#42
|
@Arcanemagus I am curious, why are you planning to re-write this to JS? I am new to the "atom world", but it seemed to me that Coffee Script had become the standard. Would you say that most packages are moving to JS now or is this a particular decision regarding the linters? |
|
Atom core itself is moving to JS, and personally I find the hacks the language does to make itself work and lack of proper tooling surrounding it make CoffeeScript unusable. |
|
Thanks! |
Implement specs and add linter.
The specs were based on the specs from linter-flake8. Added
coffeelintto the dev dependencies.Now that the specs are implemented Travis can be enabled for this repository. If it is already enabled then it just a matter of adding the .travis.yml file.
Fix #42