Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Rewrite in JS and update #122

Merged
merged 21 commits into from
Aug 10, 2017
Merged

Rewrite in JS and update #122

merged 21 commits into from
Aug 10, 2017

Conversation

Arcanemagus
Copy link
Member

Rewrite the package in JS.

Includes:

  • Fix allowed Atom version specification
  • Moving settings to a configSchema in package.json
  • Observing the settings instead of getting them each time
  • Using generateRange to highlight an entire "word" instead of single characters
  • Defering package dependency checking to an idle callback
  • Add support for $PROJECT and $PROJECT_NAME substitution in execPath
  • Allow forcing of a global configuration path
  • Update to Linter v2 API

Fixes #59.
Fixes #87.

Add a configuration based on `eslint-config-airbnb-base`. Removes
CoffeeLint.
Direct conversion of the CoffeeScript code to ES6 using `decaffeinate`.
Mainly just to ensure that the performance fix is included.
Move the configuration into `package.json`, allowing Atom to determine
the settings much faster.
Instead of forcing Atom to determine the value of a setting every time
we need to use it, observe the settings so we only deal with changes to
the values.
Instead of generating a single character range, use `generateRange` to
give us a range covering the entire word.
Properly declare the `lint()` function so that we can use `this.`
variables within it.
Load dependencies in a function that checks in a single place whether
they have already been loaded or not.
Move the check for package dependencies into an idle callback, including
an opportunistic load of the dependencies if they haven't been loaded
yet.
Add substitutions for $PROJECT and $PROJECT_NAME, largely copied and
modified from `linter-flake8`'s implementation.

Fixes #87.
Allow forcing a single configuration path for _all_ lint requests.

Fixes #59.
Update to the Linter v2 API
@Arcanemagus Arcanemagus self-assigned this Aug 9, 2017
@Arcanemagus Arcanemagus merged commit 510ae79 into master Aug 10, 2017
@Arcanemagus Arcanemagus deleted the arcanemagus/js-rewrite branch August 10, 2017 21:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant