Update eslint to version 3.0.1 🚀

[greenkeeperio-bot]

Hello lovely humans,

eslint just published its new version 3.0.1.

State	Update 🚀
Dependency	eslint
New version	3.0.1
Type	devDependency

This version is not covered by your current version range.

Without accepting this pull request your project will work just like it did before. There might be a bunch of new features, fixes and perf improvements that the maintainers worked on for you though.

I recommend you look into these changes and try to get onto the latest version of eslint.
Given that you have a decent test suite, a passing build is a strong indicator that you can take advantage of these changes by merging the proposed change into your project. Otherwise this branch is a great starting point for you to work on the update.

Do you have any ideas how I could improve these pull requests? Did I report anything you think isn’t right?
Are you unsure about how things are supposed to work?

There is a collection of frequently asked questions and while I’m just a bot, there is a group of people who are happy to teach me new things. Let them know.

Good luck with your project ✨

You rock!

🌴

---

GitHub Release

• 27700cf Fix: no-unused-vars false positive around callback (fixes #6576) (#6579) (Toru Nagashima)
• 124d8a3 Docs: Pull request template (#6568) (Nicholas C. Zakas)
• e9a2ed9 Docs: Fix rules\id-length exceptions typos (fixes #6397) (#6593) (GramParallelo)
• a2cfa1b Fix: Make outerIIFEBody work correctly (fixes #6585) (#6596) (Nicholas C. Zakas)
• 9c451a2 Docs: Use string severity in example (#6601) (Kenneth Williams)
• 8308c0b Chore: remove path-is-absolute in favor of the built-in (fixes #6598) (#6600) (shinnn)
• 7a63717 Docs: Add missing pull request step (fixes #6595) (#6597) (Nicholas C. Zakas)
• de3ed84 Fix: make no-unused-vars ignore for-in (fixes #2342) (#6126) (Oleg Gaidarenko)
• 6ef2cbe Fix: strip Unicode BOM of config files (fixes #6556) (#6580) (Toru Nagashima)
• ee7fcfa Docs: Correct type of outerIIFEBody in indent (fixes #6581) (#6584) (alberto)
• 25fc7b7 Fix: false negative of max-len (fixes #6564) (#6565) (not-an-aardvark)
• f6b8452 Docs: Distinguish examples in rules under Stylistic Issues part 6 (#6567) (Kenneth Williams)

---

The new version differs by 55 commits .

• 0fd4b6d 3.0.1
• ebf2987 Build: package.json and changelog update for 3.0.1
• 27700cf Fix: no-unused-vars false positive around callback (fixes #6576) (#6579)
• 124d8a3 Docs: Pull request template (#6568)
• e9a2ed9 Docs: Fix rules\id-length exceptions typos (fixes #6397) (#6593)
• a2cfa1b Fix: Make outerIIFEBody work correctly (fixes #6585) (#6596)
• 9c451a2 Docs: Use string severity in example (#6601)
• 8308c0b Chore: remove path-is-absolute in favor of the built-in (fixes #6598) (#6600)
• 7a63717 Docs: Add missing pull request step (fixes #6595) (#6597)
• de3ed84 Fix: make no-unused-vars ignore for-in (fixes #2342) (#6126)
• 6ef2cbe Fix: strip Unicode BOM of config files (fixes #6556) (#6580)
• ee7fcfa Docs: Correct type of outerIIFEBody in indent (fixes #6581) (#6584)
• 25fc7b7 Fix: false negative of max-len (fixes #6564) (#6565)
• f6b8452 Docs: Distinguish examples in rules under Stylistic Issues part 6 (#6567)
• 5ec54be 3.0.0

There are 55 commits in total. See the full diff.

---

This pull request was created by greenkeeper.io.

_{Tired of seeing this sponsor message? ⚡ greenkeeper upgrade}

[DanPurdy]

eslint 3.0.1 requires Node > 4.0.0 which renders any of the tests using earlier node versions a bit redundant...

[Arcanemagus]

Hmmm, an interesting case, I'd probably just leave it to the sass-lint CI testing to verify that it is running properly on those older versions, as this project is really just testing that it works within Atom.

FYI, the CI configuration needs updating to get that working, you want me to push that up like I've done to several others? Right now though the OS X builds on Travis-CI are broken, see atom/ci#43 for details.

[DanPurdy]

@Arcanemagus, yeah the only reason i had the matrix tests was due to that odd bug I was seeing with it failing on older system versions of Node when it tried to get a user's npm prefix.. Happy to remove them though. Sure if you have the time to push those updates I'd be grateful. Thanks.

[DanPurdy]

@Arcanemagus Thanks very much for this, are you happy that this is done and ready to merge? 🎉

[Arcanemagus]

I'm not sure what the status of the CI script is, the fix I proposed in atom/ci#43 turns out to still have issues if apm is used to install the modules, regardless of whether the node bundled with apm is used to run them, since eslint requires Node.js >= v4 to even install now.

@joefitzgerald's response in that issue though is "We should just update the bundled Node.js then", which I think is a bit... problematic since that means we need to wait for a stable Atom release to include that change before we can update to ESLint v3 (or anything else requiring Node.js newer than v0.10.40).

I'm still trying to come up with a good solution that doesn't break things for other packages we don't control.

tl;dr This shouldn't be merged yet.

[DanPurdy]

Yeah I had a read through that thread, does seem a little problematic to say the least..

Ok well I'll leave this on hold until I hear otherwise. In the long run it doesn't really matter what version of eslint we use as long as it gets linted. Thanks for taking the time @Arcanemagus 👍

[Arcanemagus]

This PR is superseded by #117.

(Not deleting the branch till the CI config has been split out, and any remaining changes merged into #117)