Skip to content
This repository has been archived by the owner on Aug 7, 2023. It is now read-only.

Use loophole package to to fix #104 #106

Merged
merged 2 commits into from
Aug 10, 2016

Conversation

guncha
Copy link
Contributor

@guncha guncha commented Aug 8, 2016

Atom packages are running with Content Security Policy (CSP) set to disallow eval-like behavior. Recent change in Typescript (microsoft/TypeScript#9580) added code that uses new Function(...) which will cause linter-tslint package to fail to initialize with the error as seen in #104.

This PR uses package loophole (https://github.com/atom/loophole) created by the Atom team to specifically address issues like this. I've also commented on the above mentioned PR and will try to open an issue with the Typescript team. Meanwhile, this workaround restores functionality of linter-tslint when used with typescript@next.

@dsifford
Copy link

I'm running @guncha 's patch on my machine (64-bit Linux) and it seems to be working perfectly fine.

Nice work @guncha

@Arcanemagus
Copy link
Member

Until TypeScript fixes this on their end, I guess workarounds like this are necessary. Merging and thanks!

@Arcanemagus Arcanemagus merged commit a155977 into AtomLinter:master Aug 10, 2016
@Arcanemagus
Copy link
Member

Published in v0.11.1 🎉.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants