This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Updating UTs to support both TSLint4 and TSLint5 issues #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Arcanemagus
approved these changes
Apr 13, 2017
There was a problem hiding this comment.
Actually these are v1 messages and that is the type attribute, not severity 😉.
The type attribute had no set value and was a guess as to what it associated with in linter, the severity attribute was introduced with defined values to ensure messages could be styled appropriately.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, the severity returned by this package was "Warning" (upper-case 'W') which according to this isn't valid.