This repository has been archived by the owner on Aug 7, 2023. It is now read-only.
Using local tslint #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
arusakov
commented
Feb 18, 2016
arusakov
commented
- Try using local tslint package instead of prebuilt.
- Add useLocalTslint option.
- Fix some coffeelint warnings.
- Clear code.
|
Any reason not to make this on by default? |
|
@park9140 No reason. Enable useLocalTslint by default. |
| rulesDirectory: '' | ||
| tslintCache: new Map | ||
| tslintDef: null | ||
| useLocalTslint: true |
There was a problem hiding this comment.
No need for this, the observe in activate will set it for you when the plugin is activated.
There was a problem hiding this comment.
This does help readability though, so you might want to just leave it in.
|
LGTM other than the two notes above, one of which isn't that important at all 😉. |
|
@Arcanemagus Thx for review. I left |
|
@park9140 Any further changes? |
|
|
I'll publish this tonight if no one gets to it first
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.