make warnings from the validator available rather then ignoring them

AtomLinter · Jun 29, 2016 · cb1fbe2 · cb1fbe2
1 parent 0ecc4bf
commit cb1fbe2
Show file tree

Hide file tree

Showing 3 changed files with 25 additions and 4 deletions.
diff --git a/lib/init.coffee b/lib/init.coffee
@@ -211,10 +211,17 @@ module.exports =
           messages = @parseSchematronMessages(textEditor, output)
         else
           messages = @parseSchemaMessages(textEditor, output)
-        for message in messages
-          message.type = 'Error'
-          message.text = message.text + ' (' + schemaUrl + ')'
-          message.filePath = textEditor.getPath()
+        if messages.length
+          for message in messages
+            message.type = 'Error'
+            message.text = message.text + ' (' + schemaUrl + ')'
+            message.filePath = textEditor.getPath()
+        else if output.indexOf('- validates') is -1
+          messages.push({
+            type: 'Error'
+            text: output
+            filePath: textEditor.getPath()
+          })
         return messages
 
   parseMessages: (output) ->

diff --git a/spec/fixtures/invalid/xml-model-unavailable.xml b/spec/fixtures/invalid/xml-model-unavailable.xml
@@ -0,0 +1,8 @@
+<?xml version="1.0"?>
+<?xml-model href="../unavailable.xsd" schematypens="http://www.w3.org/2001/XMLSchema"?>
+<note xmlns="http://www.w3schools.com">
+  <to>Tove</to>
+  <from>Jani</from>
+  <heading>Reminder</heading>
+  <body>Don't forget me this weekend!</body>
+</note>
diff --git a/spec/linter-xmllint-spec.coffee b/spec/linter-xmllint-spec.coffee
@@ -113,6 +113,12 @@ describe 'The xmllint provider for Linter', ->
         return lint(editor).then (messages) ->
           expect(messages.length).toEqual 1
           expect(messages[0].range).toEqual [[3, 2], [3, 21]]
+    waitsForPromise ->
+      return atom.workspace.open(__dirname + '/fixtures/invalid/xml-model-unavailable.xml').then (editor) ->
+        return lint(editor).then (messages) ->
+          expect(messages.length).toEqual 1
+          expect(messages[0].range).toEqual undefined
+          expect(messages[0].text).toContain 'unavailable.xsd'
     waitsForPromise ->
       return atom.workspace.open(__dirname + '/fixtures/invalid/relax-errors.xml').then (editor) ->
         return lint(editor).then (messages) ->