Not relying on exception for program flow #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I run our application with the library and would like to catch all exceptions not only those unhandled; then the Restore method will always throw an exception (if there id no file). With this change it will check if it exists and then return the default if it didnt exist. There is no need to try to read the stream from the file because it will not be there.
I would like to be able to set the base folder path to our application's local app data folder. Otherwise the files will not be removed when our application is removed. Since the method is public but the class is only internal, I made the class public. I know that we discussed that the default implementation could use the product name, etc. But this doesnt help because my code is loaded by a third party application, so that means that the files will be named like the application and not base on our codebase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If I run our application with the library and would like to catch all
exceptions not only those unhandled; then the Restore method will always
throw an exception (if there id no file). With this change it will check
if it exists and then return the default if it didnt exist. There is no
need to try to read the stream from the file because it will not be
there.