feat!: migration to v9 api version (tests passing)

[andreabak]

Additions to #303 with v9 migration fixes and all tests passing.

[AuHau]

This is so dope! Thanks so much for the work! 🙏 I will review it hopefully tomorrow.

[andreabak]

@AuHau I also have a branch where I've upgraded the reports API to v3 (even though v2 is not deprecated yet): andreabak@f6e2d0e
Lmk if you'd like to include this in your repo, maybe in a separate PR (it's stacked on this branch, so it'll have to wait for this to be merged first)

[Doslin]

I'm very happy to see this PR. Is there any progress so far?

[andreabak]

I'm very happy to see this PR. Is there any progress so far?

@Doslin The the code is awaiting review from @AuHau and full CI checks haven't run AFAICT. Locally all tests including integration ones are passing. There's also some small additional TODO work on the CLI side for user invites, but that's probably a niche feature anyway.

I've been using my branch in other projects since a week now (mostly entries fetching, filtering and reports) and it seems to be working fine.
While waiting on the PR to move forward, you can already test it out from my forked repo using something like this for pip install / requirements.txt: togglCli @ git+https://github.com/andreabak/toggl-cli@feat/api-v9

[AuHau]

Thanks again for pushing this to finishing line!
Here are just few initial comments, if you would be so kind to work them in.
I noticed you have added few "TODO: check" todos, so if you could either expend them to what needs to be done or remove them that would be appriciated.

I am currently trying to run the tests locally, which for some reason does not work for me and it seems the same problem is on CI (Authentication problem). I have already identified some other issues as part of that endeavor, that I am fixing up.

[AuHau]

Nice! Definitely more clean and Pythony

[AuHau]

I'm very happy to see this PR. Is there any progress so far?

Yes there is, I am slowly reviewing it and testing it locally as the test coverage is unfortunately not great and hence before merging this sort of big change I would like to be sure it won't be broken.

[andreabak]

I am currently trying to run the tests locally, which for some reason does not work for me and it seems the same problem is on CI (Authentication problem). I have already identified some other issues as part of that endeavor, that I am fixing up.

@AuHau idk if maybe related, locally I've been able to run the non-premium tests by creating a new account on toggl. And in order to make that work I had to change the workspace ID in both configs to the non-premium one, because the premium config was being used as well. I tried to look into it, but didn't come to a quick conclusion of why it was doing that, and moved on (since despite both configs, only non-premium tests seemed to run anyway). Maybe it was something wrong with my pytest config/cli or maybe there's something that needs to be tweaked in the tests setup code.

[andreabak]

@AuHau I've pushed the changes to the invite / organization code (separate commits so they're easier to review before squashing them).
I've tested the invite CLI command and it seems to work properly.

[AuHau]

Thanks! I will try to have a look on it again tomorrow. I need to figure out why tests do not work for me.

Btw. you say that tests are passing for you. Did you also run the integration tests? (I assume so) How did you go about running those? Did you set Toggl token in env. variable and then they worked?

[andreabak]

Btw. you say that tests are passing for you. Did you also run the integration tests? (I assume so) How did you go about running those? Did you set Toggl token in env. variable and then they worked?

@AuHau Yes, I've developed the changes against the integration tests and they all pass (non-premium only tho).
To make them run I had to set TOGGL_API_TOKEN in the env + changing the default_wid in the tests configs to the workspace id of my test account. (I also set log_cli = true and log_cli_level = DEBUG in pytest config and -s cli switch for debugging verbosity, but that shouldn't be relevant)

[AuHau]

Nice thanks a lot! 🙏

I have finally managed to run the tests and discovered some more bugs. I will merge this PR to my branch and fix that up there.