Make Rust version no_std and improve docs #120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Keavon
commented
Oct 7, 2023
Rust/src/lib.rs
Outdated
Comment on lines
513
to
533
| #[cfg(feature = "no_std")] | ||
| // Result is often identical, or otherwise extremely close to, std::f32::sqrt. | ||
| // In testing, the worst error seems to be around the order of magnitude of 0.00001% off. | ||
| let result = { | ||
| if f == 0. { | ||
| return 0.; | ||
| } | ||
|
|
||
| // Explanation: https://stackoverflow.com/questions/41785416/how-does-this-sqrt-approximation-inline-assembly-function-work | ||
| let mut guess = f32::from_bits((f.to_bits() + 0x3f80_0000) >> 1); | ||
|
|
||
| loop { | ||
| let new_guess = 0.5 * (guess + f / guess); | ||
| if new_guess == guess { | ||
| break; | ||
| } | ||
| guess = new_guess; | ||
| } | ||
|
|
||
| guess | ||
| }; |
There was a problem hiding this comment.
Alternatively, we could port this for the accurate implementation?
Use num-trais for no_std support
|
Could you pr these changes into the v1.1 branch, I'm getting ready to merge that to master |
|
I updated the branch and version numbering. However upon changing the base to merge this into, it looks like it created conflicts. I'll have to wait a few hours or possibly until tomorrow until I can resolve those. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.