Fix ARM Neon compilation and MulAdd implementation #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks, did you run the tests on MacOS ARM? I don't have a Mac device to test it myself |
|
Yes, I ran FastNoise2 (NewFastSIMD branch) on a MacBook with the M1 CPU. |
|
The enable_if on the mask register is to avoid ambiguous implicit conversions. The AVX512 m32 also uses it, without it there are compiler errors. What error are you getting with the enable_if? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an incorrect implementation for FMA on NEON.
I also had issues compiling the library due to the the enable_if constraint on NEON f32 register constructor. Looking at the other implementations, they don't have the enable_if, but I wasn't entirely sure what it's purpose was.
Here's a before an after for comparison:
