Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update librosa calls to fix argument errors. #14

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update librosa calls to fix argument errors. #14

wants to merge 1 commit into from

Conversation

peacheym
Copy link

@peacheym peacheym commented Apr 3, 2023

Currently the calls to librosa that handle onset detection breaks the timbral_extractor(...). Explicitly passing arguments fixes the issue.

@gionstegmann
Copy link
Contributor

Hi @brayanrodbajo,

I noticed that this pull request has been approved but hasn't been merged yet, although the modifications provided by @peacheym seem to solve the issue. Could we get an update on the status of this merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brayanrodbajo brayanrodbajo brayanrodbajo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peacheym @gionstegmann @brayanrodbajo