Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace deprecated sklearn with scikit-learn in dependencies #19

Merged
merged 2 commits into from
May 22, 2024

Conversation

gionstegmann
Copy link
Contributor

Updated the dependency list in setup.py to replace the deprecated sklearn package name with the current scikit-learn.

This update addresses the issue described in #18, where installation failures occur due to the outdated 'sklearn' package name.

@f-brinkmann
Copy link
Contributor

f-brinkmann commented May 21, 2024

Hi, thats great - thanks! I just tried a pip install -e . with Python 3.12.3 on MacOs and it worked right away. The only think I noticed is that sklearn is still mentioned in the readme.

@alastair, @ffont can this be merged and released?

@gionstegmann
Copy link
Contributor Author

sklearn is still mentioned in the readme.

fixed 👍

@ffont ffont merged commit 1ff1d47 into AudioCommons:master May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants