Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added @available checks for new canvas keyboard and removed #Preview macro #25

Closed
wants to merge 2 commits into from

Conversation

maksutovic
Copy link
Contributor

Added these as I have a project that still needs iOS 14 and #Preview macro not live for Xcode 14 yet.

} else {
Rectangle().foregroundColor(randomColors[Int(pitch.intValue) % 12])
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)

// activatedPitches: p,
// colorFunction: { x in Color(cgColor: PitchColor.helmholtz[Int(x.pitchClass)])}
// ).frame(width: 600, height: 100)
//}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)

}

//MARK: - we can have preview macro after Xcode 15 is released
//#Preview {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)

).frame(width: 600, height: 100)
}

//MARK: - we can have preview macro after Xcode 15 is released
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)
Mark Violation: MARK comment should be in valid format. e.g. '// MARK: ...' or '// MARK: - ...' (mark)

@aure aure closed this Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants