Fixes for slash notation and getRankedChords using circle of 5ths and 4ths #34
Conversation
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| } | ||
| for chord in returnArray { | ||
| print(chord, chord.accidentalCount) | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| if !returnArray.contains(chord) { | ||
| returnArray.append(chord) | ||
| } | ||
|
|
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| @@ -61,7 +61,7 @@ public class ChordTable { | |||
| } | |||
| } | |||
| } | |||
| print("generated \(returnChords.count) chords") | |||
| //print("generated \(returnChords.count) chords") | |||
There was a problem hiding this comment.
Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)
| @@ -36,7 +36,7 @@ public class ChordTable { | |||
| for chordType in ChordType.allCases { | |||
| ChordTable.generateChords(type: chordType, &r) | |||
| } | |||
| print("generated \(r.count) chords") | |||
| //print("generated \(r.count) chords") | |||
There was a problem hiding this comment.
Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)
| func testC7() { | ||
| XCTAssertEqual(Chord(.C, type: .dominantSeventh).description, "C7") | ||
| let notes: [Int8] = [60, 67, 70, 76] | ||
| let c7 = PitchSet(pitches: notes.map { Pitch($0) } ) |
There was a problem hiding this comment.
Closing Brace Spacing Violation: Closing brace with closing parenthesis should not have any whitespaces in the middle. (closing_brace)
Identifier Name Violation: Variable name should be between 3 and 40 characters long: 'c7' (identifier_name)
| @@ -22,6 +22,15 @@ class ChordTests: XCTestCase { | |||
| XCTAssertEqual(Chord.Asus2.description, "Asus2") | |||
| XCTAssertEqual(Chord.Bsus2.description, "Bsus2") | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
| @@ -12,7 +12,7 @@ final class PerformanceTests: XCTestCase { | |||
| index_sum += Note(pitch: Pitch(Int8(i))).intValue | |||
| } | |||
| if index_sum != 23779 { | |||
| print("index_sum: \(index_sum)") | |||
| //print("index_sum: \(index_sum)") | |||
There was a problem hiding this comment.
Comment Spacing Violation: Prefer at least one space after slashes for comments. (comment_spacing)
No description provided.