Skip to content

Replace ipdata with geoip db lookup #13497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raymondjacobson merged 2 commits into from
Dec 17, 2025
Merged

Replace ipdata with geoip db lookup #13497

raymondjacobson merged 2 commits into from
Dec 17, 2025

Conversation

@raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Dec 17, 2025

All nodes expose this endpoint, e.g.
https://v.monophonic.digital/storage.v1.StorageService/GetIPData?ip=23.93.215.231

Replace usages of ipdata with this endpoint

@changeset-bot
Copy link

changeset-bot bot commented Dec 17, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: b58a9cf

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

dylanjeffers
dylanjeffers approved these changes Dec 17, 2025
View reviewed changes
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nicee

rickyrombo
rickyrombo approved these changes Dec 17, 2025
View reviewed changes
packages/identity-service/src/routes/trackListens.js
const url = `https://api.ipdata.co/${ip}?api-key=${config.get(
'ipdataAPIKey'
)}`
const url = `https://creatornode.audius.co/storage.v1.StorageService/GetIPData?ip=${ip}`
Copy link
Contributor

@rickyrombo rickyrombo Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

super nit, and maybe not, but do we want to move the host to an env for easy changing?

Copy link
Member Author

@raymondjacobson raymondjacobson Dec 17, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worry a bit b/c identity runs on the old infra stack that we lose track of the env var. have thoughts on consolidating identity into the k8s stack and at that point, i think i'd go through and move a bunch of things to env (and remove others!)

@raymondjacobson raymondjacobson merged commit 429fb6d into main Dec 17, 2025
3 of 6 checks passed
@raymondjacobson raymondjacobson deleted the rj-ip branch December 17, 2025 21:24
audius-infra pushed a commit that referenced this pull request Dec 18, 2025
Audius Protocol v0.7.302
d2b9258 
[3415236] Bump version from 0.7.300 to 0.7.301 (#13503) Ray Jacobson
[429fb6d] Replace ipdata with geoip db lookup (#13497) Ray Jacobson
[f3fbf6f] Update slippage on dbc swaps (#13492) Ray Jacobson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rickyrombo rickyrombo rickyrombo approved these changes

@dylanjeffers dylanjeffers dylanjeffers approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@raymondjacobson @rickyrombo @dylanjeffers