Skip to content

Fix ssr #13561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
raymondjacobson merged 6 commits into from
Jan 7, 2026
Merged

Fix ssr #13561

raymondjacobson merged 6 commits into from
Jan 7, 2026

Conversation

@raymondjacobson
Copy link
Member

@raymondjacobson raymondjacobson commented Jan 7, 2026 •
edited
Loading

Upgrade wrangler to latest, fix vike server accordingly

Tested by:

cd packages/web

npm run start:prod
npm run start:ssr:prod

npm run build:prod
mv build-production build  
npx wrangler dev --env test

npm run build:ssr:prod
mv build-ssr-production build-ssr
npx wrangler dev --env release --config ./src/ssr/wrangler.toml

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2026 •
edited
Loading

⚠️ No Changeset found

Latest commit: 04dc081

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

raymondjacobson
raymondjacobson commented Jan 7, 2026
View reviewed changes
packages/web/src/ssr/wrangler.toml

[env.release]
name = "audius-web-ssr-release-candidate"
vars = { VITE_ENVIRONMENT = "production", DISCOVERY_NODE_ALLOWLIST = [
Copy link
Member Author

@raymondjacobson raymondjacobson Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was actually the only real change I needed, but to test locally w/ node 22, made sense to upgrade other stuff

dylanjeffers
dylanjeffers approved these changes Jan 7, 2026
View reviewed changes
Copy link
Contributor

@dylanjeffers dylanjeffers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

goood stuff

packages/web/src/ssr/polyfills.ts
@@ -0,0 +1,15 @@
/**
Copy link
Contributor

@dylanjeffers dylanjeffers Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea to consolidate

packages/web/src/ssr/worker.js
addEventListener('fetch', (event) => {
const sentry =
typeof SENTRY_DSN !== 'undefined'
export default {
Copy link
Contributor

@dylanjeffers dylanjeffers Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh interesting, what's going on here? new wrangler api?

Copy link
Member Author

@raymondjacobson raymondjacobson Jan 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah latest version requires different export style

@raymondjacobson raymondjacobson merged commit 830045a into main Jan 7, 2026
3 of 4 checks passed
@raymondjacobson raymondjacobson deleted the rj-crawler branch January 7, 2026 23:21
audius-infra pushed a commit that referenced this pull request Jan 8, 2026
Audius Protocol v0.7.307
d30709d 
[830045a] Fix ssr (#13561) Ray Jacobson
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dylanjeffers dylanjeffers dylanjeffers approved these changes

Assignees

No one assigned

Labels

size/L

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@raymondjacobson @dylanjeffers