-
Notifications
You must be signed in to change notification settings - Fork 125
Tus uploads for stems #13577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tus uploads for stems #13577
Conversation
|
| 'ddex_release_ids', | ||
| 'parental_warning_type', | ||
| 'cover_art_sizes' | ||
| 'parental_warning_type' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank god
| metadata | ||
| ) | ||
| param.onProgress(param.clientId, { | ||
| const camelMetadata = trackMetadataForUploadToSdk(snakeMetadata) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🐫🐫🐫
🐫🐍🐫
🐫🐫🐫
| endpoint: `${selectedNode}/files/`, | ||
| retryDelays: [0, 3000, 5000, 10000, 20000], | ||
| chunkSize: 100_000_000, // 100MB | ||
| removeFingerprintOnSuccess: true, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
| duration: string | ||
| bpm?: number | ||
| key?: string | ||
| } | null |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why nullable too instead of just undef?
package.json
Outdated
| "react-native-safe-area-context": "^5.6.2", | ||
| "react-native-webview": "^13.16.0", | ||
| "react-select": "5.10.1", | ||
| "tslib": "^2.8.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
piˆîn
| // Upload stem files | ||
| const stems = await uploadStemFiles(formState.tracks ?? []) | ||
|
|
||
| // Wait for track files to finish uploading before publishing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is clean, i like how it turned out
publishTrackSDK API that only maps existing upload responses to metadata and writes to chain