Skip to content

Conversation

@rickyrombo
Copy link
Contributor

  • Adds support for stems to the new TUS-based upload flow.
  • Adds new publishTrack SDK API that only maps existing upload responses to metadata and writes to chain
  • Removes superfluous logic in UploadPage that does the above
  • Refactors UploadPage to do the upload via a promise ref so that the control flow is simpler to follow

@changeset-bot
Copy link

changeset-bot bot commented Jan 14, 2026

⚠️ No Changeset found

Latest commit: 99298a0

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

'ddex_release_ids',
'parental_warning_type',
'cover_art_sizes'
'parental_warning_type'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank god

metadata
)
param.onProgress(param.clientId, {
const camelMetadata = trackMetadataForUploadToSdk(snakeMetadata)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐫🐫🐫
🐫🐍🐫
🐫🐫🐫

endpoint: `${selectedNode}/files/`,
retryDelays: [0, 3000, 5000, 10000, 20000],
chunkSize: 100_000_000, // 100MB
removeFingerprintOnSuccess: true,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

duration: string
bpm?: number
key?: string
} | null
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why nullable too instead of just undef?

package.json Outdated
"react-native-safe-area-context": "^5.6.2",
"react-native-webview": "^13.16.0",
"react-select": "5.10.1",
"tslib": "^2.8.1",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

piˆîn

// Upload stem files
const stems = await uploadStemFiles(formState.tracks ?? [])

// Wait for track files to finish uploading before publishing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is clean, i like how it turned out

@rickyrombo rickyrombo merged commit 7fa6be1 into mjp-tus-upload Jan 14, 2026
2 of 4 checks passed
@rickyrombo rickyrombo deleted the mjp-tus-stems branch January 14, 2026 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants