[PLAT-695] Add trending notifications to valid_types

[dylanjeffers]

Description

• Adds trending-playlist and trending-underground notification types to discovery-notifications "valid_types" parameter
• Refactors fetchNotification function to more accurately switch between new and old notification format.

[sabrina-kiam]

idk if this is any better or if its more confusing/longer but wondering if it would be easier to put these in a dict like:

featureFlagsToEnable = [FeatureFlags.SAVE_OF_REPOST_NOTIFICATIONS, FeatureFlags.REPOST_OF_REPOST_NOTIFICATIONS...]
isFeatureEnabled = {}
for feature in featureFlagsToEnable:
    isFeatureEnabled[feature] = yield* call(getFeatureEnabled, feature)

and then in validTypes we can access like:

  const validTypes = [
    isFeatureEnabled[FeatureFlags.REPOST_OF_REPOST_NOTIFICATIONS] ? 'repost_of_repost' : null,   
   ...
]

just wondering cuz i could see this getting clunky the more notifications we add (also sorry this is written in weird python js pseudo code lol)

[dylanjeffers]

oh yess i totally hear you, i like this!

[dylanjeffers]

i just tried and it's annoyingly just as long :/ ideally wed have a "getFeatures" function and then that returns an object than we can access. even though it's a lot of redundant code at least it's easy to understand? but yeah i hear you not the best...

[dylanjeffers]

new method:

  const validTypesFlags = [
    FeatureFlags.REPOST_OF_REPOST_NOTIFICATIONS,
    FeatureFlags.SAVE_OF_REPOST_NOTIFICATIONS,
    FeatureFlags.TRENDING_PLAYLIST_NOTIFICATIONS,
    FeatureFlags.TRENDING_UNDERGROUND_NOTIFICATIONS
  ]

  const validTypesMap: { [flag in FeatureFlags]?: boolean } = {}

  for (const validTypeFlag of validTypesFlags) {
    validTypesMap[validTypeFlag] = yield* call(getFeatureEnabled, validTypeFlag)
  }

  const validTypes = [
    validTypesMap[FeatureFlags.REPOST_OF_REPOST_NOTIFICATIONS]
      ? 'repost_of_repost'
      : null,

    validTypesMap[FeatureFlags.SAVE_OF_REPOST_NOTIFICATIONS]
      ? 'save_of_repost'
      : null,

    validTypesMap[FeatureFlags.TRENDING_PLAYLIST_NOTIFICATIONS]
      ? 'trending_playlist'
      : null,

    validTypesMap[FeatureFlags.TRENDING_UNDERGROUND_NOTIFICATIONS]
      ? 'trending_underground'
      : null
  ].filter(removeNullable)

old method:

  const isRepostOfRepostEnabled = yield* call(
    getFeatureEnabled,
    FeatureFlags.REPOST_OF_REPOST_NOTIFICATIONS
  )
  const isSaveOfRepostEnabled = yield* call(
    getFeatureEnabled,
    FeatureFlags.SAVE_OF_REPOST_NOTIFICATIONS
  )
  const isTrendingPlaylistEnabled = yield* call(
    getFeatureEnabled,
    FeatureFlags.TRENDING_PLAYLIST_NOTIFICATIONS
  )
  const isTrendingUndergroundEnabled = yield* call(
    getFeatureEnabled,
    FeatureFlags.TRENDING_UNDERGROUND_NOTIFICATIONS
  )

  const validTypes = [
    isRepostOfRepostEnabled ? 'repost_of_repost' : null,
    isSaveOfRepostEnabled ? 'save_of_repost' : null,
    isTrendingPlaylistEnabled ? 'trending_playlist' : null,
    isTrendingUndergroundEnabled ? 'trending_underground' : null
  ].filter(removeNullable)

[sabrina-kiam]

damn jk then lol you can leave however you prefer in that case!

[sabrina-kiam]

is this checking the wrong feature flag??

[dylanjeffers]

yes RIPP

[sabrina-kiam]

same here i think this is wrong feature flag?