Add minimal CI #53
Add minimal CI #53
Conversation
Adding: - `ci.yml` file describing the CI process - `drafter.yml` file to enable Release Drafter to automatically maintain the changelog - `dependabot.yml` to automatically maintain the Github Actions definitions
| - package-ecosystem: "github-actions" | ||
| directory: "/" | ||
| schedule: | ||
| interval: "weekly" |
There was a problem hiding this comment.
Will dependabot be useful, given that we only have Test and Provided dependencies? I'm not sure I want an alert when the test postgres driver makes a patch release for a vuln.
| template: | | ||
| # What's Changed | ||
|
|
||
| $CHANGES |
There was a problem hiding this comment.
This is interesting, but where does the draft release notes show up? I've never noticed them on an open source project. I just checked out the ZIO repo (which uses release-drafter), and can't find them either.
I personally don't need it since github now has a 'Generate Release Notes' button. I don't mind the default format. You can remove this for now and we can loop back later.
| java-version: 11 | ||
| check-latest: true | ||
| - name: run tests | ||
| run: sbt 'clean;test' |
There was a problem hiding this comment.
| run: sbt 'clean;test' | |
| run: sbt 'clean; scalafmtCheckAll; test' |
| steps: | ||
| - uses: release-drafter/release-drafter@v6.0.0 | ||
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
| @@ -0,0 +1,22 @@ | |||
| name: CI | |||
|
|
|||
| on: | |||
There was a problem hiding this comment.
add
push:
branches: [ "master" ]
|
|
||
| on: | ||
| pull_request: | ||
| types: [ opened, reopened, synchronize ] |
There was a problem hiding this comment.
| types: [ opened, reopened, synchronize ] | |
| branches: [ "master" ] |
Is there a reason to change this from the default Scala configuration (which is just branches: ["master"]?
| env: | ||
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} |
There was a problem hiding this comment.
| env: | |
| GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |
| permissions: | |
| contents: read |
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: coursier/cache-action@v6 |
There was a problem hiding this comment.
Does this need to be after setup-java to prevent coursier from installing its own JDK?
The default Scala CI setup on Github does not use coursier/cache-action but instead has
uses: actions/setup-java@v4
with:
java-version: '11'
distribution: 'temurin'
cache: 'sbt'
|
Actually, let me just merge and then make the changes, that will be simpler. |
Adding:
ci.ymlfile describing the CI processdrafter.ymlfile to enable Release Drafter to automatically maintain the changelogdependabot.ymlto automatically maintain the Github Actions definitions