Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loot & Plunder, For The Goddess - The Kazhkz Privateer Ship #17194

Merged
merged 33 commits into from
Nov 20, 2023

Conversation

RustingWithYou
Copy link
Contributor

Adds a House Kazhkz privateer ship, complete with ghostroles. This was meant to be finished when the Horizon was still in the Badlands, but I forgot about it and then we had a mapping freeze. Better late than never, I guess.

@BotBOREALIS BotBOREALIS added the Sprites Adds new or changes existing sprites. label Aug 31, 2023
@RustingWithYou
Copy link
Contributor Author

!review

@TheDanseMacabre
Copy link
Contributor

might be worth putting the compact francisca on the little fighter thing, will probably look neater

@DreamySkrell
Copy link
Contributor

image

  • There should be more external airlocks on the ship than just the two little ones. So the ship can be entered from more than just one side, and does not require long spacewalks. Consider places I marked with red X.
  • Add some lattices or catwalks on the outside so spacewalks around the straight and smooth hull are not pain.
  • External airlocks should be the bigger two-tile wide door variants (tiny one tile external airlocks would be fine if they weren't the only ones there).
  • Consider some more visual variety on the hallways. Now they're just really huge empty featureless hallways with the orange squares everywhere.
  • Consider filling up the foamed up space (+empty hallways) with some "utility" or storage rooms that have little function, but may bring at least a bit variety.
  • (You could ping me in the code_dungeon for help, or I could take your map, do some changes to show what I mean here and give it back later.)

@RustingWithYou
Copy link
Contributor Author

might be worth putting the compact francisca on the little fighter thing, will probably look neater

Probably, yeah. It didn't exist when I started this map, but I'll take a look at it.

@RustingWithYou
Copy link
Contributor Author

image

  • There should be more external airlocks on the ship than just the two little ones. So the ship can be entered from more than just one side, and does not require long spacewalks. Consider places I marked with red X.
  • Add some lattices or catwalks on the outside so spacewalks around the straight and smooth hull are not pain.
  • External airlocks should be the bigger two-tile wide door variants (tiny one tile external airlocks would be fine if they weren't the only ones there).
  • Consider some more visual variety on the hallways. Now they're just really huge empty featureless hallways with the orange squares everywhere.
  • Consider filling up the foamed up space (+empty hallways) with some "utility" or storage rooms that have little function, but may bring at least a bit variety.
  • (You could ping me in the code_dungeon for help, or I could take your map, do some changes to show what I mean here and give it back later.)

Hey, I don't know your Discord @ but I do broadly agree, I remember I was thinking about the halls prior to the mapping freeze. If you were to make some of the changes you have in mind on the map I'd appreciate it

@github-actions
Copy link

github-actions bot commented Sep 1, 2023

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Changelog Required and removed 🗺️ Mapping - Away Ship/Away Site The PR touches away ship and/or away site map files. labels Oct 19, 2023
@BotBOREALIS BotBOREALIS added Sprites Adds new or changes existing sprites. and removed Changelog Required labels Oct 19, 2023
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added Changelog Required and removed Merge Conflict Sprites Adds new or changes existing sprites. labels Nov 15, 2023
@BotBOREALIS BotBOREALIS added Sprites Adds new or changes existing sprites. and removed Changelog Required labels Nov 16, 2023
@github-actions github-actions bot added Changelog Required and removed Sprites Adds new or changes existing sprites. labels Nov 16, 2023
@BotBOREALIS BotBOREALIS added Sprites Adds new or changes existing sprites. and removed Changelog Required labels Nov 16, 2023
@github-actions github-actions bot added Changelog Required and removed Sprites Adds new or changes existing sprites. labels Nov 17, 2023
@BotBOREALIS BotBOREALIS added Sprites Adds new or changes existing sprites. and removed Changelog Required labels Nov 17, 2023
@github-actions github-actions bot added Changelog Required and removed Sprites Adds new or changes existing sprites. labels Nov 17, 2023
@BotBOREALIS BotBOREALIS added Sprites Adds new or changes existing sprites. and removed Changelog Required labels Nov 17, 2023
@Arrow768 Arrow768 added this pull request to the merge queue Nov 20, 2023
Merged via the queue into Aurorastation:master with commit cf82590 Nov 20, 2023
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Awaiting Merge Sprites Adds new or changes existing sprites.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants