Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ARMA 3 tests causing PHP 7.4 to fail #546

Closed
Austinb opened this issue May 3, 2020 · 1 comment · Fixed by #609
Closed

ARMA 3 tests causing PHP 7.4 to fail #546

Austinb opened this issue May 3, 2020 · 1 comment · Fixed by #609
Labels
Bug This request does fix a bug. v3

Comments

@Austinb
Copy link
Owner

Austinb commented May 3, 2020

The issue is the hexdec() call at https://github.com/Austinb/GameQ/blob/v3/src/GameQ/Protocols/Arma3.php#L156. This is new in PHP 7.4 (https://www.php.net/manual/en/migration74.deprecated.php#migration74.deprecated.core.invalid-base-characters) but is causing PHP Unit to fail out thus causing the build to fail in PHP 7.4. Not sure if the tests are bad or if something else is going on. It is data sets 2_ & 4_.

Also the tests for #382 are failing for the same reason.

@Austinb Austinb added Bug This request does fix a bug. v3 labels May 3, 2020
@bumbummen99
Copy link
Collaborator

It is also no longer working for me, failing on the mentioned line. Server is 138.201.20.99:2302. It will fail parsing the mods.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This request does fix a bug. v3
Projects
None yet
2 participants