Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ArmA 3 DLC short hashes #574

Closed
wants to merge 1 commit into from
Closed

Update ArmA 3 DLC short hashes #574

wants to merge 1 commit into from

Conversation

bumbummen99
Copy link
Collaborator

@bumbummen99 bumbummen99 commented Apr 8, 2021

Added new Art of War DLC, updated all shortHash for all DLC, removed Enoch as it is part of the Contact DLC. Enoch = Livonia.
Query will still fail on parsing the steamID64 (Reference #546)

There also seems to be a new ServerBrowserProtocolV3

@scrutinizer-notifier
Copy link

The inspection completed: No new issues

@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.798% when pulling 781aa1c on bumbummen99:patch-1 into af6641c on Austinb:v3.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage remained the same at 87.798% when pulling 781aa1c on bumbummen99:patch-1 into af6641c on Austinb:v3.

@bumbummen99 bumbummen99 changed the title Update DLC short hashes Update ArmA 3 DLC short hashes Apr 8, 2021
@Austinb
Copy link
Owner

Austinb commented May 14, 2021

Test data needs to be updated. I can try to get to it soon but very busy with other projects currently. Sorry.

@Austinb Austinb self-assigned this May 14, 2021
@bumbummen99
Copy link
Collaborator Author

Test data needs to be updated. I can try to get to it soon but very busy with other projects currently. Sorry.

There is more to it, it did not work back when i checked at all due to #546 but now it will also need the new SOG DLC short hash.
In the meantime the normal query can be used tought it will not contain arma specific information.

If anyone wants to check his server log and PR into my branch that would be awesome :+1

@stale
Copy link

stale bot commented Jun 16, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Marked as stale label Jun 16, 2021
@bumbummen99
Copy link
Collaborator Author

Not stale

@stale stale bot removed the Stale Marked as stale label Jun 16, 2021
@stale
Copy link

stale bot commented Jul 14, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Stale Marked as stale label Jul 14, 2021
@bumbummen99
Copy link
Collaborator Author

Not stale

@stale stale bot removed the Stale Marked as stale label Jul 14, 2021
@Austinb Austinb added Bug This request does fix a bug. v3 labels Jul 23, 2021
@bumbummen99
Copy link
Collaborator Author

These are already out of date again

@bumbummen99
Copy link
Collaborator Author

#585

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug This request does fix a bug. v3
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants