Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DNS Mocking #616

Merged
merged 16 commits into from
May 22, 2022
Merged

DNS Mocking #616

merged 16 commits into from
May 22, 2022

Conversation

bumbummen99
Copy link
Collaborator

@bumbummen99 bumbummen99 commented May 22, 2022

Currenlty tests using actual hosts will fail once the DNS records change. My preferred method of choice would be to monkey patch gethostbyname and get rid of phpunit mocks.

Fixes #604

@coveralls
Copy link

coveralls commented May 22, 2022

Coverage Status

Coverage decreased (-6.8%) to 87.918% when pulling 0bac556 on dns-mocking into 01700ea on v3.

@scrutinizer-notifier
Copy link

A new inspection was created.

@bumbummen99 bumbummen99 merged commit 6888fbb into v3 May 22, 2022
@bumbummen99 bumbummen99 added the Enhancement This request does add something to the project. label Aug 10, 2022
@Austinb Austinb deleted the dns-mocking branch February 25, 2023 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement This request does add something to the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DNS mocking
3 participants