Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Projects/App.js: memoize all the things #1703

Open
wants to merge 1 commit into
base: filterbar-context
Choose a base branch
from

Conversation

chadoh
Copy link
Collaborator

@chadoh chadoh commented Dec 3, 2019

We do not need or want to recalculate all of this stuff on every render
of App.js. In particular, this caused the entire Tabs bar and TabAction
(with associated MiniFilterBar) to be removed from the DOM and re-added
on every render.

To do before merge:

We do not need or want to recalculate all of this stuff on every render
of App.js. In particular, this caused the entire Tabs bar and TabAction
(with associated MiniFilterBar) to be removed from the DOM and re-added
on every render.
@chadoh chadoh requested a review from rkzel December 3, 2019 16:13
@ottodevs ottodevs self-assigned this Dec 11, 2019
@ottodevs ottodevs self-requested a review December 11, 2019 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants