Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix own accounts message #423

Closed
MithrandirCraft opened this issue Jan 7, 2016 · 32 comments
Closed

Fix own accounts message #423

MithrandirCraft opened this issue Jan 7, 2016 · 32 comments
Assignees
Milestone

Comments

@MithrandirCraft
Copy link

I don't know how you guys will find this, but there's currently an option for viewing related accounts when someone logs in, as long as you have the "authme.player.seeotheraccounts" permission.

I would like to suggest a permission for viewing one's own account names when logging in, or a command for such checking purpose.

This would be usefull for players who want to unregister some accounts because they have exceded the limit :) But it may have some negative downsides.


Spigot version: 1.8.8
Authme version: 5.2-SNAPSHOT-b596

@ljacqu
Copy link
Member

ljacqu commented Jan 8, 2016

That sounds like a nice idea! Since we can associate it with a permission node, a plugin admin can then decide if he wants to allow it or not. So no downsides per se ^^

@Xephi
Copy link
Contributor

Xephi commented Jan 9, 2016

Check if it works

@Xephi Xephi added Status: please verify Status: awaiting answer Marks issues blocked by an open question to the reporter. labels Jan 9, 2016
@MithrandirCraft
Copy link
Author

Permission node, Command or New config?

@Xephi
Copy link
Contributor

Xephi commented Jan 9, 2016

Permission node
authme.player.seeownaccounts

@MithrandirCraft
Copy link
Author

Not working.

I applied the permission to all groups, and applied build 672.

@sgdc3
Copy link
Member

sgdc3 commented Jan 9, 2016

@Xephi

@sgdc3 sgdc3 removed Status: awaiting answer Marks issues blocked by an open question to the reporter. Status: please verify labels Jan 9, 2016
@sgdc3 sgdc3 added this to the 5.2 Release milestone Jan 9, 2016
@sgdc3 sgdc3 closed this as completed in 18ed62b Feb 20, 2016
@ljacqu
Copy link
Member

ljacqu commented Feb 20, 2016

@MithrandirCraft Is this still an open issue? (Issue was closed by merge to Xephi/master; with particular wording in commits issues can be auto-closed)

@ljacqu ljacqu reopened this Feb 20, 2016
@MithrandirCraft
Copy link
Author

@ljacqu This isn't an issue, it's a suggestion :)
Anyway, I still havent got the change to test if the latest builds already apply this. I am quite stable at the moment (I don't want to move from my dev build, unless you recommend me any more advanced one.), I'm currently waiting for a full release on bukkit.

@MithrandirCraft
Copy link
Author

Ok. I can confirm this is still not working.

@sgdc3 sgdc3 changed the title (Suggestion) Checking other accounts Fix own accounts message Mar 31, 2016
@ljacqu ljacqu self-assigned this Apr 23, 2016
@ljacqu ljacqu assigned sgdc3 and unassigned ljacqu May 5, 2016
@ljacqu
Copy link
Member

ljacqu commented Jun 11, 2016

@sgdc3 What is still open for this?

@sgdc3
Copy link
Member

sgdc3 commented Jun 11, 2016

@MithrandirCraft i don't remember what was missing :/

@sgdc3 sgdc3 added the Status: awaiting answer Marks issues blocked by an open question to the reporter. label Jun 11, 2016
@MithrandirCraft
Copy link
Author

It basically just doesn't work.
Setting up the permission: authme.player.seeownaccounts
doesn't show one's own accounts on entering the server.

Authme version:
screenshot_2

@sgdc3
Copy link
Member

sgdc3 commented Jun 11, 2016

894 is old xD

@MithrandirCraft
Copy link
Author

@sgdc3 This was implemented + suposedly fixed before 894. So If you didn't do any changes related to this issue since then, I'd say the issue will still persist.

  • Updating Authme to a new dev build is something risky and rerrifying xD

@sgdc3
Copy link
Member

sgdc3 commented Jun 13, 2016

It only shows the own accounts if you have more than 1 registered account per IP

@ljacqu
Copy link
Member

ljacqu commented Jun 13, 2016

@MithrandirCraft Could we ask you to verify this again please? I've tested on 1.8.8 with PermissionsBukkit and it behaves as expected.
@sgdc3 The green names for online players is really nice... :)

@ljacqu ljacqu added Status: please verify and removed Status: awaiting answer Marks issues blocked by an open question to the reporter. labels Jun 13, 2016
@sgdc3 sgdc3 closed this as completed Jun 15, 2016
@sgdc3
Copy link
Member

sgdc3 commented Jun 15, 2016

Works as intended

@sgdc3
Copy link
Member

sgdc3 commented Jun 15, 2016

@MithrandirCraft

@MithrandirCraft
Copy link
Author

MithrandirCraft commented Jun 15, 2016

I'm on it. Updating authme is no game xD

@MithrandirCraft
Copy link
Author

MithrandirCraft commented Jun 15, 2016

The feature is implemented successfully :) It works! Just one thing, where can I change the "You own X accounts" message?

It hasn't shown up yet on the locale. Can I add it myself? If so, how would the format be?

@sgdc3
Copy link
Member

sgdc3 commented Jun 15, 2016

just look at the English locale, it should include the key

@sgdc3
Copy link
Member

sgdc3 commented Jun 15, 2016

@ljacqu we need to run the tools again

@ljacqu
Copy link
Member

ljacqu commented Jun 15, 2016

@sgdc3 You know how, right? :) Good practice. We need someone else who knows the tools

@MithrandirCraft
Copy link
Author

I really can't find the You own X accounts message anywhere. Can you give me the line?

@MithrandirCraft
Copy link
Author

Maybe the server needs another restart.

@ljacqu
Copy link
Member

ljacqu commented Jun 15, 2016

@MithrandirCraft At the bottom of https://github.com/AuthMe-Team/AuthMeReloaded/blob/master/src/main/resources/messages/messages_en.yml

Opened #768 for creating a command that will automatically "pull" new messages into a user's messages file.

@ljacqu
Copy link
Member

ljacqu commented Jun 16, 2016

@sgdc3 Can you run the task for the messages please?

@sgdc3
Copy link
Member

sgdc3 commented Jun 16, 2016

Yeah, just give me 2 hours, i'm not at pc now.

@sgdc3
Copy link
Member

sgdc3 commented Jun 16, 2016

I'll also replace the release jar

@ljacqu
Copy link
Member

ljacqu commented Jun 16, 2016

@sgdc3 Thanks! The reason I ask you to do it is to make sure you know how, and that it works on your end ;)

@sgdc3
Copy link
Member

sgdc3 commented Jun 16, 2016

@ljacqu yeah it works but how to add the missing messages to the language files? xD

@ljacqu
Copy link
Member

ljacqu commented Jun 16, 2016

Run verifyMessages and pay attention to the options (I think it doesn't write the missing ones by default, need to enter y)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

4 participants