Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a command for updating the messages file #768

Closed
ljacqu opened this issue Jun 15, 2016 · 1 comment
Closed

Create a command for updating the messages file #768

ljacqu opened this issue Jun 15, 2016 · 1 comment
Assignees
Milestone

Comments

@ljacqu
Copy link
Member

ljacqu commented Jun 15, 2016

As we add more messages to the yml file it becomes difficult for server owners to update their YML files without losing their custom messages. Create a child command of /authme that gets new messages from the JAR's messages and adds it to the user's file.

  • should we do a backup before changing it?
  • if we have a file of the same language (e.g. messages_de.yml), copy missing messages from there
  • copy remaining messages from messages_en.yml
    • optionally add them as comments only as our tool task does, but then you need to make sure that the command can be run multiple times without adding the same comment each time
  • edit the error message in the Messages class to refer to the new command (the "Error getting message with key...")
  • update the commands page (tool task createCommandPage)

Hint: load messages with Bukkit's YamlConfiguration

@ljacqu
Copy link
Member Author

ljacqu commented Jun 15, 2016

Another idea is to do such a check on startup and adding new messages that are missing, but I'm not sure if it's a good idea to do it without a user's "consent".

@ljacqu ljacqu self-assigned this Oct 10, 2016
@ljacqu ljacqu added this to the 5.2 milestone Oct 16, 2016
@ljacqu ljacqu closed this as completed Oct 18, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant